Page MenuHomePhabricator
Create Task
Maniphest T416542

Log entries for automatic global group membership changes are created on local wikis, not Meta
Closed, ResolvedPublic
Actions

Description

Log entries for automatic global group membership changes are created on local wikis, not Meta. For example: https://en.wikibooks.org/wiki/Special:Log/gblrights (taken from T397224#11376026).

Is this expected? Until now I thought that all global group membership changes should happen on Meta. On the other hand, https://en.wikipedia.org/wiki/Special:Log/gblrights also has some real global group membership changes from 2014 and earlier. Is this something we changed at some point (maybe T19308?), or is it still okay?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Logging: more tests for DatabaseLogEntrymediawiki/coremaster+59 -3
Logging: Support interacting with log entries from other wikismediawiki/coremaster+161 -19
GlobalGroupAssignmentService: Insert log entries into central wikimediawiki/extensions/CentralAuthmaster+83 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Wed, Feb 4, 11:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 4, 11:52 PM
JJMC89 subscribed.Thu, Feb 5, 1:17 AM

They should only be on metawiki.

Stewards used to be able to make such changes on any wiki, but T207531 / this change moved the relevant rights from the global group to the local metawiki one so that the logs would be centralized.

Johannnes89 subscribed.Thu, Feb 5, 7:16 AM
Tchanders subscribed.Thu, Feb 5, 10:34 AM

Here is our original discussion on logging: T376315#10413649.

My understanding is that this is considered to be acceptable because the checkuser and suppress groups are updated via meta.

This fitted our use-case (though we didn't think of the case where a user who is currently in one of those groups is only added to the global group when some other local group changes - T416541).

But I guess it would need revisiting for T415588, if bot could be added anywhere.

matmarex mentioned this in T415588: Add rate limit class for accounts that are in a local bot group on any wiki.Thu, Feb 5, 9:13 PM
NguoiDungKhongDinhDanh subscribed.Thu, Feb 5, 10:11 PM
gerritbot added a comment.Fri, Feb 6, 9:01 PM

Change #1237587 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Logging: Support interacting with log entries from other wikis

https://gerrit.wikimedia.org/r/1237587

gerritbot added a project: Patch-For-Review.Fri, Feb 6, 9:01 PM

Change #1237589 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] GlobalGroupAssignmentService: Insert log entries into central wiki

https://gerrit.wikimedia.org/r/1237589

matmarex added a comment.Fri, Feb 6, 9:03 PM

MediaWiki has some cross-wiki capabilities, but they are not complete in this area, and so I had to make some workarounds. I think this is acceptable, but if it isn't, another approach we could take would be to insert the log entry from a job that would always run on Meta-Wiki, but could be scheduled cross-wiki (we do something similar for account vanishing).

matmarex claimed this task.Fri, Feb 6, 9:52 PM
matmarex added a parent task: T415588: Add rate limit class for accounts that are in a local bot group on any wiki.
matmarex moved this task from Inbox, needs triage to Q3 Kanban Board on the MediaWiki-Platform-Team board.
matmarex edited projects, added MediaWiki-Platform-Team (Q3 Kanban Board); removed MediaWiki-Platform-Team.
matmarex moved this task from Essential Work to In Progress on the MediaWiki-Platform-Team (Q3 Kanban Board) board.
gerritbot added a comment.Sun, Feb 15, 12:55 PM

Change #1239518 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Logging: more tests for DatabaseLogEntry

https://gerrit.wikimedia.org/r/1239518

gerritbot added a comment.Sun, Feb 15, 1:20 PM

Change #1237587 merged by jenkins-bot:

[mediawiki/core@master] Logging: Support interacting with log entries from other wikis

https://gerrit.wikimedia.org/r/1237587

gerritbot added a comment.Sun, Feb 15, 1:20 PM

Change #1237589 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalGroupAssignmentService: Insert log entries into central wiki

https://gerrit.wikimedia.org/r/1237589

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Sun, Feb 15, 2:00 PM
gerritbot added a comment.Sun, Feb 15, 8:57 PM

Change #1239518 merged by jenkins-bot:

[mediawiki/core@master] Logging: more tests for DatabaseLogEntry

https://gerrit.wikimedia.org/r/1239518

Maintenance_bot removed a project: Patch-For-Review.Sun, Feb 15, 9:30 PM
matmarex closed this task as Resolved.Tue, Feb 17, 4:12 AM

This will be fixed for future log entries (once the new code rolls out to all wikis this Thursday).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits