Page MenuHomePhabricator

Improve test coverage of SpecialMWOAuthManageConsumers
Open, Needs TriagePublic

Description

SpecialMWOAuthManageConsumers is the flow that allows OAuth administrators to review and manage approvals, rejections, and other actions for the consumer requests queue. It also lists approved and disabled consumers.

Integration tests would be written to cover related logic in ConsumerSubmitControl for endpoints such as: /approve, /reject, /disable, /reenable, and code that lists the consumer requests queue. Unit tests can be written for self-contained functionality where needed. It's probably possible to use SpecialPageTestBase, since this will involve testing a special page and ApiTestCase for action API-related functionality.

Impact

Event Timeline

Lower priority as OAuth admins are mostly WMF staff, so we'll notice quickly if something breaks.

Disable / reenable are in theory possible for owner-only consumers, so maybe worth having a test for that, although in practice that's never used. The others are meaningful for normal consumers only.

I don't think there are meaningful differences between OAuth 1 and 2 here.