Page MenuHomePhabricator
Create Task
Maniphest T416558

Streamline InternalList properties used for mapping references
Open, Needs TriagePublic
Actions

Description

Context

ve.dm.InternalList currently maintains at least two properties used to map indexes with listKeys. ve.dm.InternalList.keys and ve.dm.InternalList.keyIndexes. Since we want to introduce a new mechanism to map MWReferenceNodes with InternalItemNodes we're revisiting what's actually useful here.

Insights

ve.dm.InternalList.keys seems to be incomplete and thereby useless because it's only used with the listKey and not the listGroup and is therby not a useful map.
ve.dm.InternalList.keyIndexes seems only relevant in two places

  • when the Convert adds InternalItemNodes for references in ve.dm.InternalList.queueItemHtml
  • when two InternalLists are merged in ve.dm.InternalList.merge
Task

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Feb 5 2026, 9:31 AM
gerritbot added a comment.Feb 5 2026, 9:33 AM

Change #1236757 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Remove unused InternalList.keys property

https://gerrit.wikimedia.org/r/1236757

gerritbot added a project: Patch-For-Review.Feb 5 2026, 9:33 AM

Change #1236790 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Stop reading duplicate InternalList.keys data structure

https://gerrit.wikimedia.org/r/1236790

gerritbot added a comment.Feb 5 2026, 10:27 AM

Change #1237164 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Track if keyIndexes are used on InternaList.merge()

https://gerrit.wikimedia.org/r/1237164

WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2026-02-03-Tomatoes-of-many-colors board.Feb 5 2026, 10:27 AM
gerritbot added a comment.Feb 5 2026, 1:04 PM

Change #1236790 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Stop reading duplicate InternalList.keys data structure

https://gerrit.wikimedia.org/r/1236790

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Feb 5 2026, 2:00 PM
gerritbot added a comment.Feb 5 2026, 7:38 PM

Change #1237308 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Document that NodeGroup.indexOrder not correlates with listIndex

https://gerrit.wikimedia.org/r/1237308

WMDE-Fisch updated the task description. (Show Details)Feb 6 2026, 9:47 AM
WMDE-Fisch updated the task description. (Show Details)
gerritbot added a comment.Feb 9 2026, 11:19 AM

Change #1237869 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Revert "VE: Change ve.dm.Transaction.test to cover input from copy and paste"

https://gerrit.wikimedia.org/r/1237869

gerritbot added a comment.Feb 9 2026, 7:42 PM

Change #1237869 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Revert "VE: Change ve.dm.Transaction.test to cover input from copy and paste"

https://gerrit.wikimedia.org/r/1237869

Lina_Farid_WMDE moved this task from Incoming to NOW on the Cite (Sub-referencing) board.Feb 12 2026, 10:47 AM
gerritbot added a comment.Feb 13 2026, 8:42 AM

Change #1237308 abandoned by WMDE-Fisch:

[VisualEditor/VisualEditor@master] Document that NodeGroup.indexOrder does not relate to listIndex

Reason:

A had a few more pokes here and I think it is actually usable to get the order if the first appearance of a "node using a listIndex". So my comment is invalid.

https://gerrit.wikimedia.org/r/1237308

gerritbot added a comment.Feb 13 2026, 8:48 AM

Change #1236757 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Remove unused InternalList.keys property

https://gerrit.wikimedia.org/r/1236757

WMDE-Fisch mentioned this in T415770: Revert changes that made more use of keyIndexes.Feb 13 2026, 10:38 AM
MareikeHeuerWMDE moved this task from Tech Review to Epics / Watching / Stalled on the WMDE-TechWish-Sprint-2026-02-03-Tomatoes-of-many-colors board.Feb 13 2026, 11:16 AM
gerritbot added a comment.Feb 13 2026, 11:18 AM

Change #1237164 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Track if keyIndexes are used on InternaList.merge()

https://gerrit.wikimedia.org/r/1237164

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2026, 11:30 AM
gerritbot added a comment.Feb 13 2026, 6:13 PM

Change #1217218 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (17a600756)

https://gerrit.wikimedia.org/r/1217218

gerritbot added a project: Patch-For-Review.Feb 13 2026, 6:13 PM
gerritbot added a comment.Feb 13 2026, 7:50 PM

Change #1217218 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (17a600756)

https://gerrit.wikimedia.org/r/1217218

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17); removed: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Feb 13 2026, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 13 2026, 8:31 PM
gerritbot added a comment.Mar 12 2026, 1:18 PM

Change #1251078 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Use ve.err to track potential issues

https://gerrit.wikimedia.org/r/1251078

gerritbot added a project: Patch-For-Review.Mar 12 2026, 1:18 PM
gerritbot added a comment.Mar 13 2026, 12:20 PM

Change #1251078 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use ve.error to track potential issues

https://gerrit.wikimedia.org/r/1251078

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2026, 12:31 PM
thiemowmde updated the task description. (Show Details)Mar 14 2026, 12:47 PM
gerritbot added a comment.Mar 18 2026, 12:18 PM

Change #1254901 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7585187b3)

https://gerrit.wikimedia.org/r/1254901

gerritbot added a project: Patch-For-Review.Mar 18 2026, 12:18 PM
gerritbot added a comment.Mar 18 2026, 1:26 PM

Change #1254901 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7585187b3)

https://gerrit.wikimedia.org/r/1254901

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2026, 1:31 PM
WMDE-Fisch mentioned this in T424659: [Epic] Code cleanup for sub-referencing.Jun 1 2026, 8:28 AM
thiemowmde added a parent task: T424659: [Epic] Code cleanup for sub-referencing.Jun 2 2026, 7:25 AM
gerritbot added a comment.Jun 4 2026, 11:11 AM

Change #1297650 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] [WIP] Document ve.dm.InternalList.keyIndexes better

https://gerrit.wikimedia.org/r/1297650

gerritbot added a project: Patch-For-Review.Jun 4 2026, 11:11 AM
gerritbot added a comment.Jun 5 2026, 10:45 AM

Change #1298142 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Drop dead code from ve.dm.InternalList#merge

https://gerrit.wikimedia.org/r/1298142

gerritbot added a comment.Jun 8 2026, 9:34 AM

Change #1298718 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add safe-guard to MWReferenceNode.remapInternalListIndexes

https://gerrit.wikimedia.org/r/1298718

gerritbot added a comment.Jun 8 2026, 9:47 AM

Change #1298719 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Remove meaningless identity from internalList mapping

https://gerrit.wikimedia.org/r/1298719

gerritbot added a comment.Jun 9 2026, 10:03 PM

Change #1297650 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Document ve.dm.InternalList.keyIndexes much better

https://gerrit.wikimedia.org/r/1297650

gerritbot added a comment.Jun 9 2026, 10:19 PM

Change #1298718 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add safe-guard to MWReferenceNode.remapInternalListIndexes

https://gerrit.wikimedia.org/r/1298718

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.7; 2026-06-16).Jun 9 2026, 11:00 PM
gerritbot added a comment.Jun 11 2026, 10:31 AM

Change #1300740 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8d3a1a849)

https://gerrit.wikimedia.org/r/1300740

gerritbot added a comment.Jun 11 2026, 3:50 PM

Change #1300740 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8d3a1a849)

https://gerrit.wikimedia.org/r/1300740

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits