[{reqId}] {exception_url} TypeError: Unsupported operand types: array + nullThat solely happens on ruwiki and we had 25 of them since promoting to all wikis. I do not know about the consequence, maybe people don't get logged in properly or it just an issue when creating the personal URLs?
Change #1237272 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] TypeError: Unsupported operand types: array + null
The error is actually in SkinTemplate.
For this specific stack trace, the impact is your user toolbar not being updated when you get logged in automatically. That is not very significant, no need to block deployment because of it. SkinTemplate might error out in other situations though.
I can't replicate this locally, but this fix is logical since notifications key may not exist in certain skins if they don't support it cc @Ammarpad
I can reproduce. The key is deleted by Vector legacy. I believe ruwiki still uses it as the default skin.
They do. Actually, it was my first thought reading the blockers task that if it happens only there, the old skin could be very possibly the problem.
Where is it deleted by Vector legacy ? Can you point me to the code and provide some reproduction instructions?
Change #1237302 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Vector legacy: empty rather than unset
It seems you found it. https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1237302. I left a comment there.
Change #1237302 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] Vector legacy: empty rather than unset
Reason:
Recommendation is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1237272 for now.
Change #1237272 merged by jenkins-bot:
[mediawiki/core@master] TypeError: Unsupported operand types: array + null
@hashar fix is merged now, can be backported and we should be good to go: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1237272
Change #1237489 had a related patch set uploaded (by Hashar; author: Jdlrobson):
[mediawiki/core@wmf/1.46.0-wmf.14] TypeError: Unsupported operand types: array + null
I have exchanged with federico3, one of the SRE on call and he kindly approved of it. During our discussion we noted I have mentioned the change got reproduced which led to the test and that were reviews by multiple people.
A point to note is that SkinTemplate::buildPersonalUrls() has no test coverage for either the loggedin or not loggedin paths: https://doc.wikimedia.org/cover/mediawiki-core/includes/Skin/SkinTemplate.php.html#424 . That would not have caught that specific issue which originate from Vector rather than core. Even though the code base is several years old, i might benefit some unit tests, since the hotfix having a test helps building some level of confidence ;]
Change #1237489 merged by jenkins-bot:
[mediawiki/core@wmf/1.46.0-wmf.14] TypeError: Unsupported operand types: array + null
Mentioned in SAL (#wikimedia-operations) [2026-02-06T14:46:01Z] <hashar@deploy2002> Started scap sync-world: Backport for [[gerrit:1237489|TypeError: Unsupported operand types: array + null (T416619)]]
Mentioned in SAL (#wikimedia-operations) [2026-02-06T14:50:28Z] <hashar@deploy2002> hashar: Backport for [[gerrit:1237489|TypeError: Unsupported operand types: array + null (T416619)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2026-02-06T14:57:24Z] <hashar@deploy2002> Finished scap sync-world: Backport for [[gerrit:1237489|TypeError: Unsupported operand types: array + null (T416619)]] (duration: 11m 23s)
I have deployed the fix and the error is gone. Thank you!
I am not sure whom to assigning the task to, so I am leaving it unassigned.