Page MenuHomePhabricator

[Bug] IP info box shows error when clicking the link to view contributions from all related TA
Open, Needs TriagePublic

Description

Steps to reproduce

  • Open contributions page for a TA with connected accounts
  • In the alert box, Click on "View all contributions from these accounts"
  • Click on IP info box

What is happening

  • IP info box displays an error

What should've happened

  • IP information should be displayed

Examples: https://test.wikipedia.org/w/index.php?title=Special:Contributions&title=Special%3AContributions%2F%7E2026-44956-9&showRelatedTemporaryAccounts=1

Event Timeline

Specifically, this happens if the first revision line is from a temporary account who wasn't the original target.

There is some logic in ext.ipInfo/infobox/init.js that expects that the first revision ID on the page belongs to the main target, but if there are related temporary accounts with more recent contributions, this assumption is violated.

Change #1237487 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] infobox/init.js: Fix rev ID fetching for temp user contributions

https://gerrit.wikimedia.org/r/1237487

Change #1237487 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] infobox/init.js: Fix rev ID fetching for temp user contributions

https://gerrit.wikimedia.org/r/1237487

Specifically, this happens if the first revision line is from a temporary account who wasn't the original target.

This means the IP info is visible again if show-related mode is turned off again

dom_walden subscribed.

I cannot reproduce this particular bug. There are some other bugs (e.g. T417250) and more testing will be done when those are fixed.