Per parent task
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix bad data in contribution_tracking source and banner for app donations. | wikimedia/fundraising/crm | master | +37 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | SNowick_WMF | T415692 Apps Big EN 2025 Banner Name and Impression data /campaign_id mismatch - to be investigated | |||
| Resolved | Lars | T416722 Add missing B2526 to source/banner in CiviCRM for app donations |
Event Timeline
Comment Actions
Change #1238052 had a related patch set uploaded (by Lars SG; author: Lars SG):
[wikimedia/fundraising/crm@master] Fix bad data in contribution_tracking source and banner for app donations.
Comment Actions
Fix in above patch does the following (refer to parent task for list to fix):
- Adds the missing _ in TestAndroid and TestiOS for the two sources and banners that are missing it.
- Adds the missing B2526 campaign to all the source and banners in the list (except the first one, which I have handled by hand).
Comment Actions
@Eileenmcnaughton No impact on channel, these are all medium = WikipediaApp and so they are and remain Channel = Wikipedia App.
And yeah, I could have made that patch simpler, oh well.
Comment Actions
Change #1238052 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Fix bad data in contribution_tracking source and banner for app donations.
Comment Actions
@SKivlehan-WMF These have now been corrected. I think the new data should be in Metabase by the morning.
Comment Actions
Thank you for the work on this last week, @Lars -- I will confirm with Shay that the impressions data all looks correct from the apps team's view.