Remove empty file options
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Redmin
	Sat, Feb 7, 10:09 AM

Description

Linter can complain about empty file options due to the presence of extraneous pipes.

Tasks:

Add code to carry out transformations like this without making any unrelated change to delinter.py: [[File:Example.jpg|thumb||right]] → [[File:Example.jpg|thumb|right]], [[File:Example.jpg|arbitrary||right]] → [[File:Example.jpg|arbitrary|right]] etc.
Add tests to test_delinter.py

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	T416767: Fix empty file options in test_delinter	toolforge-repos/redminbot!14	nagam-surya-narayana	T416767-fix	main

Customize query in GitLab

Related Objects

Mentioned In: T417269: Request approval for Wikimedia GitLab account
Mentioned Here: T417269: Request approval for Wikimedia GitLab account
R3311:d8466da3f194: Edit test_delinter.py

Event Timeline

Redmin created this task.Sat, Feb 7, 10:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Feb 7, 10:09 AM

Redmin moved this task from Triage to Up Next on the Tool-redminbot board.Sat, Feb 7, 10:09 AM

Redmin triaged this task as Low priority.Thu, Feb 12, 12:59 AM

Hi, I’d like to work on this task if it’s still available.
I’m new to Wikimedia contributions and recently submitted a Pywikibot patch.

Redmin added a project: patch-welcome.Thu, Feb 12, 10:34 AM

Redmin updated the task description. (Show Details)

In T416767#11609773, @NAGAM_SURYA_NARAYANA wrote:

Hi, I’d like to work on this task if it’s still available.
I’m new to Wikimedia contributions and recently submitted a Pywikibot patch.

Hi, yep, you can submit a patch for this if you have an account on Wikimedia GitLab. The repository is located here: https://gitlab.wikimedia.org/toolforge-repos/redminbot/.

NAGAM_SURYA_NARAYANA mentioned this in T417269: Request approval for Wikimedia GitLab account.Thu, Feb 12, 12:46 PM

Hi @Redmin,
I checked the current upstream main branch and it already contains the fix for empty file options (commit d8466da – Edit test_delinter.py).
It seems this task is already resolved. Could you please confirm and close the task if appropriate?
Thank you.

The code currently only removes file options that only have nowiki tags with no content in between them. The aim of this task is to make it carry out a different transformation so extraneous pipes (|) are removed.

Hi @Redmin,
This patch implements removal of extraneous empty file options in [[File:...]] links, as discussed in T417269. All relevant tests in test_delinter.py pass (45 tests), and only delinter.py and test_delinter.py were modified. The changes are ready for review and merge.
Thanks!