Page MenuHomePhabricator

Use 'add' icon in new-label button
Closed, ResolvedPublicBUG REPORT

Description

The 'new label' button has a + character, but the 'delete' button has a proper icon.

image.png (281×76 px, 3 KB)

The first button should use an 'add' icon. Before T406372 is done, the icon HTML will need to be constructed manually.

Thanks to @jhsoby for pointing out this bug.

Event Timeline

Samwilson changed the task status from Open to In Progress.Feb 11 2026, 5:02 AM
Samwilson claimed this task.

Change #1238605 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Special:WatchlistLabels: Use proper icon for 'add' button

https://gerrit.wikimedia.org/r/1238605

As mentioned on gerrit:

image.png (783×553 px, 56 KB)

I've tried clearing the cache etc..

That's odd. I can't replicate. What is your config for $wgLocalisationCacheConf?

That's odd. I can't replicate. What is your config for $wgLocalisationCacheConf?

It's the default that DevelopmentSettings.php sets :/
$wgLocalisationCacheConf['store'] = 'array';

If you comment out $wgLocalisationCacheConf does it work? Do you have $wgCacheDirectory set?

I really need to tidy up my localsettings.. managed to fix this and its working as expected :)

Change #1238605 merged by jenkins-bot:

[mediawiki/core@master] Special:WatchlistLabels: Use proper icon for 'add' button

https://gerrit.wikimedia.org/r/1238605

dom_walden subscribed.

The HTML on enwiki beta is:

<a href="/wiki/Special:WatchlistLabels/edit" class="cdx-button cdx-button--fake-button cdx-button--fake-button--enabled cdx-button--action-progressive cdx-button--weight-primary"><span class="cdx-button__icon mw-specialwatchlistlabels-icon--add" aria-hidden="true"></span> New label</a>