Page MenuHomePhabricator

VisualEditor gives "Something went wrong" warning when edit summary reminders are enabled
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Preferences and enable "Prompt me when entering a blank edit summary (or the default undo summary)"
  • Try to edit a page with VisualEditor, and leave the edit summary field blank
  • Publish changes

What happens?:

A blocking "Something went wrong" overlay appears on top of the dialog box. It has an option to retry which works when pressed. Functionality is otherwise unimpaired.

What should have happened instead?:

There shouldn't be an overlay.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): 1.46.0-wmf.14

Other information (browser name/version, screenshots, etc.):

Pre-submissionBugged stateResulting dialog after dismissal
Screenshot 2026-02-09 at 14-15-41 Editing User Chlod_sandbox - Wikipedia.png (365×500 px, 22 KB)
Screenshot 2026-02-09 at 14-15-56 Editing User Chlod_sandbox - Wikipedia.png (543×498 px, 36 KB)
Screenshot 2026-02-09 at 14-16-02 Editing User Chlod_sandbox - Wikipedia.png (545×500 px, 35 KB)

Event Timeline

Potentially Regression related to 023e989? The edit seems to have added a reject to the "missing summary" flow that wasn't there before. cc @Dreamy_Jazz; I currently don't have much experience working with this file so I'm not sure of the consequences of just having that flow resolve the promise instead, though a cursory glance at the context (T407202) and the tests added tells me this is not something you'd want.

Change #1237946 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: adjust when saveDeferred is rejected

https://gerrit.wikimedia.org/r/1237946

Change #1237946 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: adjust when saveDeferred is rejected

https://gerrit.wikimedia.org/r/1237946

✅ No overlay

⚠️ 2 icons: 1 info and a warning banner. New ticket will be created to track this

image.png (1×1 px, 176 KB)

I checked into that a bit, and it's specifically a problem on the beta cluster. It's got an overridden missingsummary message that explicitly includes that big (i) icon. So this is a case of "the VE save dialog is displaying exactly what the on-wiki overrides are asking it to display". 🤷🏻

It's fine on e.g. enwiki:

CleanShot 2026-02-12 at 12.25.09@2x.png (1×1 px, 234 KB)

I checked into that a bit, and it's specifically a problem on the beta cluster. It's got an overridden missingsummary message that explicitly includes that big (i) icon. So this is a case of "the VE save dialog is displaying exactly what the on-wiki overrides are asking it to display". 🤷🏻

It's fine on e.g. enwiki:

CleanShot 2026-02-12 at 12.25.09@2x.png (1×1 px, 234 KB)

Interesting

EAkinloose edited projects, added Verified; removed Editing QA.