Page MenuHomePhabricator

Apply changes button should be active only if there are changes.
Closed, ResolvedPublic

Description

The "apply changes" button for the settings dialog should be initially disabled and become active once there is a change in the settings that may be saved by the user.


Version: master
Severity: normal

Details

Reference
bz39685

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:12 AM
bzimport set Reference to bz39685.

We have to discuss this one. Srikanth doesn't see how this can be done given the current degrees of freedom. Let's plan this for a daily or a 3-way chat.

It doesn't look too hard to me, but I may be missing something.

Here's a proposed fix for the Display Settings panel:
https://gerrit.wikimedia.org/r/#/c/34688/