Page MenuHomePhabricator

ToolLinksHandlerTest: Unrecognized parameter type MobileContext
Closed, ResolvedPublic

Description

Seen on https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82/26492/console for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1237274 (seemingly unrelated patch)

Presumably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1236340 whre tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php wasn't updated

18:31:56 There were 6 failures:
18:31:56 
18:31:56 1) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnUserToolinksEditWhenRequestTitleIsNull
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:31
18:31:56 
18:31:56 2) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnUserToolinksEditWrongNamespace
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:46
18:31:56 
18:31:56 3) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnUserToolinksEditWrongSpecialPage with data set "Special:History" ('Special:History', array('History'))
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:69
18:31:56 
18:31:56 4) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnUserToolinksEditWrongSpecialPage with data set "Special:About" ('Special:About', array('About'))
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:69
18:31:56 
18:31:56 5) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnUserToolinksEditWrongSpecialPage with data set "Special:Diff with subpage" ('Special:Diff/1234', array('Diff', '1234'))
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:69
18:31:56 
18:31:56 6) MediaWiki\CheckUser\Tests\Unit\HookHandler\ToolLinksHandlerTest::testOnContributionsToolLinksNoRights
18:31:56 Unrecognized parameter type MobileContext
18:31:56 
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:60
18:31:56 /workspace/src/tests/phpunit/mocks/MockServiceDependenciesTrait.php:32
18:31:56 /workspace/src/extensions/CheckUser/tests/phpunit/unit/HookHandler/ToolLinksHandlerTest.php:92

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy triaged this task as High priority.Feb 9 2026, 6:45 PM
Reedy updated the task description. (Show Details)

Change #1237980 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CheckUser@master] unit/ToolLinksHandlerTest.php: Specifically set mobileContext parameter to null

https://gerrit.wikimedia.org/r/1237980

Marking UBN as it's affecting numerous repos

Reedy raised the priority of this task from High to Unbreak Now!.Feb 9 2026, 7:03 PM

This should be fixed...

Change #1237980 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] unit/ToolLinksHandlerTest: Specifically set mobileContext parameter to null

https://gerrit.wikimedia.org/r/1237980

This should be fixed...

Thanks! CI passed for my patch.