Page MenuHomePhabricator
Create Task
Maniphest T416941

IPReputation: Remove IPReputationEnableLoginCaptchaIfIPKnown and associated logic
Closed, ResolvedPublic
Actions

Description

Summary

IPReputationEnableLoginCaptchaIfIPKnown was added as a stopgap in the context of {T389727}. We don't need this variable anymore, and should remove the variable and the code that uses it.

Acceptance criteria

  • IPReputationEnableLoginCaptchaIfIPKnown is removed, along with any code that relies on it
  • operations/mediawiki-config has IPReputationEnableLoginCaptchaIfIPKnown removed

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop $wgIPReputationEnableLoginCaptchaIfIPKnownDreamy Jazzoperations/mediawiki-configmaster+0 -5
ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnownSTranmediawiki/extensions/IPReputationwmf/1.46.0-wmf.14+0 -129
ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnownKosta Harlanmediawiki/extensions/IPReputationmaster+0 -129
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Feb 9 2026, 11:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2026, 11:01 PM
gerritbot added a comment.Feb 9 2026, 11:16 PM

Change #1238056 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@master] ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnown

https://gerrit.wikimedia.org/r/1238056

gerritbot added a project: Patch-For-Review.Feb 9 2026, 11:16 PM
kostajh claimed this task.Feb 9 2026, 11:24 PM
kostajh edited projects, added: Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)); removed: Product Safety and Integrity.
kostajh moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)); removed: Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)).Feb 10 2026, 9:07 AM
OKryva-WMF moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)) board.Feb 10 2026, 9:08 AM
gerritbot added a comment.Feb 10 2026, 1:56 PM

Change #1238056 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@master] ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnown

https://gerrit.wikimedia.org/r/1238056

kostajh mentioned this in rEIPR270d9b7aa674: ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnown.Feb 10 2026, 1:56 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Feb 10 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2026, 2:31 PM
gerritbot added a comment.Feb 11 2026, 1:51 PM

Change #1238713 had a related patch set uploaded (by STran; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnown

https://gerrit.wikimedia.org/r/1238713

gerritbot added a project: Patch-For-Review.Feb 11 2026, 1:51 PM
gerritbot added a comment.Feb 11 2026, 1:54 PM

Change #1238713 abandoned by STran:

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] ConfirmEdit: Remove IPReputationEnableLoginCaptchaIfIPKnown

Reason:

bad rebase

https://gerrit.wikimedia.org/r/1238713

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2026, 2:32 PM
Dreamy_Jazz moved this task from Needs review to In progress on the Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)) board.Feb 11 2026, 8:36 PM
Dreamy_Jazz updated the task description. (Show Details)Feb 17 2026, 1:03 PM
gerritbot added a comment.Feb 18 2026, 10:21 AM

Change #1240227 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Drop $wgIPReputationEnableLoginCaptchaIfIPKnown

https://gerrit.wikimedia.org/r/1240227

gerritbot added a project: Patch-For-Review.Feb 18 2026, 10:21 AM
gerritbot added a comment.Feb 23 2026, 11:17 AM

Change #1240227 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop $wgIPReputationEnableLoginCaptchaIfIPKnown

https://gerrit.wikimedia.org/r/1240227

Stashbot added a comment.Feb 23 2026, 11:25 AM

Mentioned in SAL (#wikimedia-operations) [2026-02-23T11:25:29Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1240227|Drop $wgIPReputationEnableLoginCaptchaIfIPKnown (T416941)]]

Stashbot added a comment.Feb 23 2026, 11:27 AM

Mentioned in SAL (#wikimedia-operations) [2026-02-23T11:27:44Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1240227|Drop $wgIPReputationEnableLoginCaptchaIfIPKnown (T416941)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Dreamy_Jazz closed this task as Resolved.Feb 23 2026, 11:29 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from In progress to Done on the Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)) board.
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2026, 11:30 AM
Stashbot added a comment.Feb 23 2026, 11:32 AM

Mentioned in SAL (#wikimedia-operations) [2026-02-23T11:32:27Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1240227|Drop $wgIPReputationEnableLoginCaptchaIfIPKnown (T416941)]] (duration: 06m 58s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits