Page MenuHomePhabricator

Suggested investigations: Trigger auto-closure on lock and global block
Closed, ResolvedPublic

Description

In T414979: Close the cases when all accounts are already blocked a mechanism for automatically closing certain cases was implemented. This mechanism is triggered when user is locally blocked. However, the other kinds of blocking do not invoke it now.

Given that we'd like all three kinds of blocks (local, global, and blocks) to allow for auto-closing, we should treat all of them as triggers for auto-closure.

Acceptance criteria

Unblocked, without a specifier means "not affected by any of the three types of blocks"

  • When there's only one unblocked user in a SI case, and this user gets globally blocked, auto-closure job is triggered on the wiki where the global block was placed. (As long as $wgApplyGlobalBlocks is true on that wiki).
  • When there's only one unblocked user in a SI case, and this user gets locked, auto-closure job is triggered on the wiki where the lock was placed.

Non-goals of this task (will be handled in separate tasks):

  • Triggering the auto-close job on other wikis in the cluster

Event Timeline

Change #1239924 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CheckUser@master] Trigger auto-close SI case when user is globally locked or blocked

https://gerrit.wikimedia.org/r/1239924

Change #1239941 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CentralAuth@master] CentralAuthGlobalUserLocked: Add hook for global account locking

https://gerrit.wikimedia.org/r/1239941

Change #1239941 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CentralAuthGlobalUserLocked: Add hook for global account locking/unlock

https://gerrit.wikimedia.org/r/1239941

Change #1239924 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Trigger auto-close SI case when user is globally locked or blocked

https://gerrit.wikimedia.org/r/1239924

dom_walden subscribed.

I see we run the auto-close job when creating or updating a global block (including globally blocking multiple users via Special:MassGlobalBlock) and when locking a user.

We don't run it when removing a local whitelist for a global block nor when updating a lock (e.g. changing the lock reason).

Dreamy_Jazz updated the task description. (Show Details)