Page MenuHomePhabricator

Conduct holistic QA of Suggestion Mode MVP release
Closed, ResolvedPublic

Description

Over the past several weeks, we've merged, and discretely QA'd, a range of new Suggestions within – and features and fixes for – Suggestion Mode.

This task involves the work of holistically QA'ing the Suggestion Mode MVP release.

Requirements

  1. Visit https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures
  2. Enable Suggestion mode (if it's not already)
  3. On mobile and desktop respectively...
    1. Open a range of Wikipedia articles with Suggestions present within them (T397379)
  4. File tickets for what (if any) issues and unexpected behaviors you notice
  5. List the tickets you end up filing in the === Issues/Observations section below

Of course, please raise anything that cause you to wonder whether something warrants a ticket or not.

Issues/Observations

Screenshot 2026-02-24 at 7.59.06 PM.png (2,724×536 px, 300 KB)

  • Crossing out the Suggestion Card causes the page appear zoomed in, making the side rail along with all other suggestions and checks go out of view on mobile. - This has been fixed.

Observations:

Scenario 1: When you have a paragraph tagged with Revise tone suggestion and you start editing that paragraph but then move your cursor somewhere else, it keeps that as a suggestion.

Scenario 2: When you have a paragraph tagged with Revise tone suggestion and you start editing that paragraph but then press return to go to the next line it converts that suggestion to check.

Shouldn't the suggestion in the first scenario convert to a check in the same way as it does in the second scenario? Is it intentional?

Event Timeline

Ryasmeen updated the task description. (Show Details)

@Ryasmeen: thank you for reviewing Suggestion Mode and documenting what you noticed. Assuming it's accurate for me to think you've completed reviewing the feature and updated the task description with all that you found unexpected, could you please file tickets for the following issues?

  • "...marker for Convert Reference suggestion is not aligned with the paragraph." issue?
  • "Crossing out the Suggestion Card causes the page appear zoomed in, making the side rail along with all other suggestions and checks go out of view on mobile."
  • "When you have a paragraph tagged with Revise tone suggestion and you start editing that paragraph but then move your cursor somewhere else, it keeps that as a suggestion."

With regard to the scenarios you helpfully identified here...

  • Scenario 1: When you have a paragraph tagged with Revise tone suggestion and you start editing that paragraph but then move your cursor somewhere else, it keeps that as a suggestion.
    • This sounds expected to me.
      • Thinking: b/c you did not write the text you're opting into revising the tone of, the interface does not expect/require you to follow through in addressing the issue Tone Check predicts to be present. As such, it makes sense to me that a Suggestion continue to be shown, rather than a Check.
  • Scenario 2: When you have a paragraph tagged with Revise tone suggestion and you start editing that paragraph but then press return to go to the next line it converts that suggestion to check.

Interesting I thought the opposite to be expected and my thinking was that as soon as I started typing or modifying that paragraph, it kind of becomes my edit in a sense that the suggestion that was applicable for the entire paragraph, has now been modified into "a new paragraph" which is an addition in the current edit session and hence it should be considered as check instead of suggestion.

But yeah, if suggestions are not designed to behave in this way for this scenario, then we should probably fix scenario 2 to not convert the Suggestion into Check for consistency .

@ppelberg moving this task to the current sprint so that you can address it.