Page MenuHomePhabricator

Watchlist labels data appears in wrong place in group mode
Open, Needs TriagePublicBUG REPORT

Description

Hi.

  • Open a watchlist in group mode with a labeled page that has multiple edits shown.
  • Expected: the text "Labels: <labels>" appears once above the collapsed area.
  • Got: the same text appears many times on each line in collapsed area, while it never can be different from line to line for the same page.

Screenshot_20260211_101911_Samsung Internet.png (244×1 px, 171 KB)

Thank you.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1239979 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] EnhancedChangesList: Show watchlist labels once (on header)

https://gerrit.wikimedia.org/r/1239979

Change #1239979 merged by jenkins-bot:

[mediawiki/core@master] EnhancedChangesList: Show watchlist labels once (on header)

https://gerrit.wikimedia.org/r/1239979

As a task creator, I just checked this in 17 different cases on Beta Cluster, and it works fine, thank you.
Btw, the Action API setnotificationstamp doesn't work there, do not know if it's a bug or in purpose.

@IKhitron @TheresNoTime What about logged actions? For example, block logs of user whose user page you have watched or account creation logs. They get grouped together even though you might have a different label for each user's talk page.

block_log.png (385×1 px, 81 KB)

account_creation.png (368×874 px, 67 KB)

@IKhitron @TheresNoTime What about logged actions? For example, block logs of user whose user page you have watched or account creation logs. They get grouped together even though you might have a different label for each user's talk page.

Looks like it already there, no?

image.png (803×956 px, 73 KB)

@IKhitron @TheresNoTime What about logged actions? For example, block logs of user whose user page you have watched or account creation logs. They get grouped together even though you might have a different label for each user's talk page.

Looks like it already there, no?

But is this what we want, considering that pages might get grouped together which don't have the same labels.

Now I understand. Yes, maybe better to remove the label combining on logs or check if they are identical, or take only identical while leaving distinct. Good catch.