Page MenuHomePhabricator
Create Task
Maniphest T417199

Improve performance of getModifiedLinkRanges on long articles
Open, Needs TriagePublic
Actions

Description

On [[Georgia_(U.S._state)]] this takes about 500ms, mostly checking each link to see if it is in a valid section.

We should probably pre-compute the section ranges to optimise for this slow case.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditCheckFactory: run all checks inside a requestIdleCallbackmediawiki/extensions/VisualEditormaster+38 -31
WIP: Per-node cache that gets invalidated by relevant transactions onlyVisualEditor/VisualEditormaster+154 -19
getModifiedAnnotationRanges: Improve performancemediawiki/extensions/VisualEditormaster+5 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Wed, Feb 11, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 11, 4:42 PM
Esanders moved this task from Decisions to be made to Ready to Be Worked On on the Editing-team (Editing-2Feb-17Feb-2026) board.Wed, Feb 11, 5:56 PM
gerritbot added a comment.Wed, Feb 11, 6:27 PM

Change #1238791 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] getModifiedAnnotationRanges: Improve performance

https://gerrit.wikimedia.org/r/1238791

gerritbot added a project: Patch-For-Review.Wed, Feb 11, 6:27 PM
gerritbot added a comment.Wed, Feb 11, 7:13 PM

Change #1238791 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] getModifiedAnnotationRanges: Improve performance

https://gerrit.wikimedia.org/r/1238791

Maintenance_bot removed a project: Patch-For-Review.Wed, Feb 11, 7:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Wed, Feb 11, 8:00 PM
gerritbot added a comment.Thu, Feb 12, 6:17 PM

Change #1238825 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckFactory: run all checks inside a requestIdleCallback

https://gerrit.wikimedia.org/r/1238825

gerritbot added a project: Patch-For-Review.Thu, Feb 12, 6:17 PM
gerritbot added a comment.Tue, Feb 17, 5:59 PM

Change #1240003 had a related patch set uploaded (by Divec; author: Divec):

[VisualEditor/VisualEditor@master] WIP: Per-node cache that gets invalidated by relevant transactions only

https://gerrit.wikimedia.org/r/1240003

ppelberg assigned this task to dchan.Tue, Feb 17, 6:20 PM
ppelberg moved this task from Ready to Be Worked On to Doing on the Editing-team (Editing-2Feb-17Feb-2026) board.
ldelench_wmf added a project: OKR-Work.Tue, Feb 17, 6:20 PM
ldelench_wmf edited projects, added Editing-team (Editing-2Mar-13Mar-2026); removed Editing-team (Editing-2Feb-17Feb-2026).Wed, Mar 4, 3:04 PM
ldelench_wmf moved this task from Decisions to be made to Doing on the Editing-team (Editing-2Mar-13Mar-2026) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits