Page MenuHomePhabricator
Create Task
Maniphest T417199

Improve performance of getModifiedLinkRanges on long articles
Closed, ResolvedPublic
Actions

Description

On [[Georgia_(U.S._state)]] this takes about 500ms, mostly checking each link to see if it is in a valid section.

We should probably pre-compute the section ranges to optimise for this slow case.

See also T418532 for relevant performance benchmarks

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
EditCheckFactory: run all checks inside a requestIdleCallbackDLynchmediawiki/extensions/VisualEditormaster+98 -62
Update VE core submodule to master (c8db73677)Esandersmediawiki/extensions/VisualEditormaster+1 -1
Per-node cache that gets invalidated by relevant transactions onlyDivecVisualEditor/VisualEditormaster+155 -18
getModifiedAnnotationRanges: Improve performanceEsandersmediawiki/extensions/VisualEditormaster+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Feb 11 2026, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2026, 4:42 PM
Esanders moved this task from Decisions to be made to Ready to Be Worked On on the Editing-team (Editing-2Feb-17Feb-2026) board.Feb 11 2026, 5:56 PM
gerritbot added a comment.Feb 11 2026, 6:27 PM

Change #1238791 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] getModifiedAnnotationRanges: Improve performance

https://gerrit.wikimedia.org/r/1238791

gerritbot added a project: Patch-For-Review.Feb 11 2026, 6:27 PM
gerritbot added a comment.Feb 11 2026, 7:13 PM

Change #1238791 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] getModifiedAnnotationRanges: Improve performance

https://gerrit.wikimedia.org/r/1238791

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2026, 7:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Feb 11 2026, 8:00 PM
gerritbot added a comment.Feb 12 2026, 6:17 PM

Change #1238825 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckFactory: run all checks inside a requestIdleCallback

https://gerrit.wikimedia.org/r/1238825

gerritbot added a project: Patch-For-Review.Feb 12 2026, 6:17 PM
gerritbot added a comment.Feb 17 2026, 5:59 PM

Change #1240003 had a related patch set uploaded (by Divec; author: Divec):

[VisualEditor/VisualEditor@master] WIP: Per-node cache that gets invalidated by relevant transactions only

https://gerrit.wikimedia.org/r/1240003

ppelberg assigned this task to dchan.Feb 17 2026, 6:20 PM
ppelberg moved this task from Ready to Be Worked On to Doing on the Editing-team (Editing-2Feb-17Feb-2026) board.
ldelench_wmf added a project: OKR-Work.Feb 17 2026, 6:20 PM
ldelench_wmf edited projects, added: Editing-team (Editing-2Mar-17Mar-2026); removed: Editing-team (Editing-2Feb-17Feb-2026).Mar 4 2026, 3:04 PM
ldelench_wmf moved this task from Decisions to be made to Doing on the Editing-team (Editing-2Mar-17Mar-2026) board.
gerritbot added a comment.Mar 6 2026, 3:45 PM

Change #1240003 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Per-node cache that gets invalidated by relevant transactions only

https://gerrit.wikimedia.org/r/1240003

gerritbot added a comment.Mar 9 2026, 12:52 PM

Change #1249278 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c8db73677)

https://gerrit.wikimedia.org/r/1249278

gerritbot added a comment.Mar 9 2026, 6:10 PM

Change #1249278 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c8db73677)

https://gerrit.wikimedia.org/r/1249278

ppelberg subscribed.EditedMar 18 2026, 4:19 PM

@dchan: can you please share what (if anything) is left to be done here? Further, can you please help me understand the impact of us not optimizing the performance of getModifiedLinkRanges?

VPuffetMichel subscribed.Mar 25 2026, 8:58 PM

Should this task be resolved? @dchan @Esanders
I see patches that are +2.

dchan added a comment.Mar 26 2026, 6:06 PM

Oh, this (merged) patch should also have been tagged:

https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/1244785/

dchan closed this task as Resolved.Mar 26 2026, 6:06 PM
dchan added a subtask: T418532: Speed up ve.dm.BranchNode#getAnnotationRanges with better caching.
dchan updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits