Page MenuHomePhabricator

[Minerva TOC] Invisible header should not be interactive
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Background

Even when it's not supposed to show because the user has not scrolled that far, the sticky header element already exists (for keyboard tabbing, for visits with #toc anchor, and for getting its size), but has a 0 opacity.
However... it is still there, can be interacted with, and interferes with whatever is below it: clicking the mobile top-left hamburger menu icon actually triggers the TOC, because that button is (invisibly) on top of it.
That obviously shouldn't happen.

The screen recording shows the z-index issue: when users tap/click the mobile hamburger menu icon, the invisible TOC toggle button layered on top captures the interaction instead.

Acceptance Criteria

  • The sticky header cannot intercept clicks meant for elements beneath its position

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedBUG REPORTmatthiasmullie

Event Timeline

Change #1238772 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Make sure invisible header is stacked below other content

https://gerrit.wikimedia.org/r/1238772

Change #1238772 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Make sure invisible header is stacked below other content

https://gerrit.wikimedia.org/r/1238772

lwatson set the point value for this task to 1.
Etonkovidova subscribed.

Checked on enwiki beta - looks as expected - no interaction with the TOC when it's hidden.

scroll_toc3.gif (1,160×925 px, 2 MB)