Page MenuHomePhabricator
Create Task
Maniphest T417208

Cover HomepageHooks::onCirrusSearchAddQueryFeatures and HelpPanelHooks::getPreferredEditor with integration testing
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Due to a bug in T410917 (r1234408), we accidentally caused T417195: Unexpected call to ConfigurationLoader::getTaskTypes when feature is disabled (February 2026) (an UBN). To avoid similar breakages in the future, we should add at least a basic integration tests coverage to this method.

The problem was checking for $geServices->getFeatureManager()->isNewcomerTasksAvailable() rather than !$geServices->getFeatureManager()->isNewcomerTasksAvailable() (inversed condition).

Fixing patches:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add integration tests to cover ConfigurationLoader when SE disabledmediawiki/extensions/GrowthExperimentsmaster+59 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Feb 11 2026, 5:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2026, 5:10 PM
Urbanecm_WMF mentioned this in T417195: Unexpected call to ConfigurationLoader::getTaskTypes when feature is disabled (February 2026).Feb 11 2026, 5:10 PM
Urbanecm_WMF renamed this task from Cover HomepageHooks::onCirrusSearchAddQueryFeatures with integration testing to Cover HomepageHooks::onCirrusSearchAddQueryFeatures and with integration testing.Feb 11 2026, 6:09 PM
Urbanecm_WMF renamed this task from Cover HomepageHooks::onCirrusSearchAddQueryFeatures and with integration testing to Cover HomepageHooks::onCirrusSearchAddQueryFeatures and HelpPanelHooks::getPreferredEditor with integration testing.
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF triaged this task as Medium priority.Feb 11 2026, 6:17 PM
Urbanecm_WMF moved this task from Inbox to Needs Estimation on the Growth-Team board.

This would've helped to prevent two errorbursts in the past ~2 months: T417195, T408531. Moving to Current Quarter Backlog (no objections if someone pulls to sprint if they have time).

Cyndymediawiksim claimed this task.Feb 12 2026, 9:48 AM
gerritbot added a comment.Feb 12 2026, 10:29 AM

Change #1239019 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Add integration tests to cover ConfigurationLoader when SE disabled

https://gerrit.wikimedia.org/r/1239019

gerritbot added a project: Patch-For-Review.Feb 12 2026, 10:29 AM
Cyndymediawiksim set the point value for this task to 0.5.Feb 12 2026, 10:36 AM
Cyndymediawiksim edited projects, added Growth-Team (FY2025-26 Q3 Sprint 3); removed Growth-Team.
Cyndymediawiksim moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q3 Sprint 3) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q3 Sprint 3) board.Feb 12 2026, 1:56 PM
gerritbot added a comment.Feb 12 2026, 2:21 PM

Change #1239019 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add integration tests to cover ConfigurationLoader when SE disabled

https://gerrit.wikimedia.org/r/1239019

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2026, 2:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Feb 12 2026, 3:00 PM
Urbanecm_WMF edited projects, added Growth-Team (FY2025-26 Q3 Sprint 4); removed Growth-Team (FY2025-26 Q3 Sprint 3).Feb 24 2026, 5:34 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (FY2025-26 Q3 Sprint 4) board.
Etonkovidova closed this task as Resolved.Mar 4 2026, 4:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits