Page MenuHomePhabricator

CI will not permit test data to be added
Closed, ResolvedPublic

Description

I think we just need to add ext/*/tests to the exclude - probably core/tests too

Not sure where this is configured though....

11:58:25 Valid JSON (./ext/wmf-civicrm/tests/phpunit/Civi/WMFAudit/data/Braintree/donation/braintree/incoming/settlement_batch_report_2022-06-28.json)
11:58:25 ./ext/wmf-civicrm/tests/phpunit/Civi/WMFAudit/data/Braintree/raw_batch/braintree/incoming/raw_disbursement_report_consolidated_2026-01-15_2026-01-15.json: Parse error on line 1:

Script jsonlint $(find . -type f -iname "*.json" ! -path "*/vendor/*" ! -path "*/bower*" ! -path "*/tests/data/*" ! -path "*/civicrm/*/afform*" -printf "%p ") handling the test event returned with error code 1

Event Timeline

https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/refs/heads/master/composer.json#74

"jsonlint $(find . -type f -iname \"*.json\" ! -path \"*/vendor/*\" ! -path \"*/bower*\" ! -path \"*/tests/data/*\" ! -path \"*/civicrm/*/afform*\" -printf \"%p \")"

If you're purposefully putting invalid json files (syntactically, not necessarily to schema) it might make sense to not give them a .json filename

@Reedy I'm purposefully putting in test data that has the same features as the real data - but thanks - I had missed that place!!!

Eileenmcnaughton claimed this task.
Eileenmcnaughton set Final Story Points to 1.