Page MenuHomePhabricator

Email addresses containing + cannot be double opted in
Closed, ResolvedPublic

Description

Acoustic can't url-encode the email address for us, so the result is the + in the url is interpreted as a space (any + after the ? is considered a space).
So far our only potential solution is to send the url-encoded email up to Acoustic as a separate field, but we can't do this in SQL. We could just replace the + in SQL, but that seems like a pretty weak solution.

Event Timeline

Change #1239388 had a related patch set uploaded (by Lars SG; author: Lars SG):

[mediawiki/extensions/DonationInterface@master] Replace space with + in email addresses before validation

https://gerrit.wikimedia.org/r/1239388

Change #1239388 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Replace space with + in email addresses before validation

https://gerrit.wikimedia.org/r/1239388

Lars moved this task from Backlog to Done on the Fundraising Tech - Chaos Crew board.
Lars moved this task from Done to In Progress on the Fundraising Tech - Chaos Crew board.

We should also url-encode the email when we are sending from CiviCRM directly.

XenoRyet triaged this task as Medium priority.Tue, Feb 17, 9:08 PM
XenoRyet moved this task from In Progress to Done on the Fundraising Tech - Chaos Crew board.
XenoRyet set Final Story Points to 2.