When the editor initially loads and there are suggestions present, those "suggestion-shown" events should be logged; they currently are not.
Noticed this from confusing data in the Superset dashboard where "suggestion-seen" events were outnumbering "suggestion-shown" events, when this should be impossible.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T360489 [EPIC] Generate and present edit suggestions at scale | |||
| Resolved | DLynch | T410188 Add ability to know how often Checks/Suggestions are *shown* to Edit Check dashboard | |||
| Resolved | BUG REPORT | medelius | T417452 EditCheck VEFU instrumentation not correctly logging initial "shown" events |
Change #1239310 had a related patch set uploaded (by Medelius; author: Medelius):
[mediawiki/extensions/VisualEditor@master] EditCheck: update shown stats on initial page load
Change #1239310 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] EditCheck: update shown stats on initial page load
Change #1240041 had a related patch set uploaded (by Medelius; author: Medelius):
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.15] EditCheck: update shown stats on initial page load
Change #1240041 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.15] EditCheck: update shown stats on initial page load
Mentioned in SAL (#wikimedia-operations) [2026-02-17T21:22:38Z] <kemayo@deploy2002> Started scap sync-world: Backport for [[gerrit:1240041|EditCheck: update shown stats on initial page load (T417452)]], [[gerrit:1240043|EditCheck: adjust editsuggestion-seen tag (T413419)]]
Mentioned in SAL (#wikimedia-operations) [2026-02-17T21:46:59Z] <kemayo@deploy2002> caro, kemayo: Backport for [[gerrit:1240041|EditCheck: update shown stats on initial page load (T417452)]], [[gerrit:1240043|EditCheck: adjust editsuggestion-seen tag (T413419)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2026-02-17T22:03:05Z] <kemayo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1240041|EditCheck: update shown stats on initial page load (T417452)]], [[gerrit:1240043|EditCheck: adjust editsuggestion-seen tag (T413419)]] (duration: 40m 26s)
We realized in post-backport data analysis that this would also be affecting the check-shown-midedit events for the growth-suggested-tone check, which is initialized onto the page during initial loading.
(It was also affecting mid-edit checks that were present on the page when an autosave was restored -- but (a) we knew that already, and (b) that's not many things currently, so we don't think that particularly impacted any numbers.)