Background
One of the big successes of dark mode was that it drove a lot of Codex design token adoption as interfaces that used custom colors broke in dark mode. In a few select cases we worked around this with the expectation that over time we would replace those custom colors with dark mode.
Back in December we introduced a public mixin called darkmode-custom-fix which is currently only used by DiscussionTools.
We'd like to discourage its use as this could move us towards a pattern that's harder to maintain on the long-term (for example: deprecating mixins has been very difficult historically) and we should not be encouraging extension developers to favor "custom dark fixes" over evolving with the Codex design system.
User story
As a developer I want to be guided about the best way to integrate dark mode for my extension/skin.
Requirements
- Dark mode best practices are documented on mediawiki.org
- Use of the mixin should trigger a stylelint warning. https://github.com/wikimedia/stylelint-config-wikimedia/pull/256 which links to the above best pratices
- The mixin is named before it sees further adoption
- DiscussionTools is patched to use the new name
- Upgrade to v0.19.2 of stylelint-config-wikimedia
- As a best practice it should error if used in core. We shouldn't add any new instances to core.
BDD
- For QA engineer to fill out
Test Steps
- For QA engineer to fill out
Design
- Add mockups and design requirements
Acceptance criteria
- Add acceptance criteria
Communication criteria - does this need an announcement or discussion?
- Add communication criteria
Rollback plan
- What is the rollback plan in production for this task if something goes wrong?
This task was created by Version 1.2.0 of the Web team task template using phabulous