Page MenuHomePhabricator
Create Task
Maniphest T417471

Refactor buildContentNavigationUrlsInternal
Open, MediumPublic
Actions

Description

The buildContentNavigationUrlsInternal method is many lines long making it hard to reason with. Refactoring it would support optimizing skin generation by allowing us to only generate menus when needed in T331360: Allow skins to optimize the data the template receives.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Separate buildContentNavigationUrlsAssociatedPages from main functionmediawiki/coremaster+32 -23
Separate buildContentNavigationUrlsViews from main functionmediawiki/coremaster+126 -110
Separate buildContentNavigationUrlsActions from main functionmediawiki/coremaster+83 -68
Separate buildContentNavigationUrlsVariants from functionmediawiki/coremaster+49 -36
Separate buildContentNavigationUrlsLinks from main functionmediawiki/coremaster+13 -7
Separate buildContentNavigationUrlsWatchAction from main functionmediawiki/coremaster+60 -41
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Fri, Feb 13, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Feb 13, 11:36 PM
Jdlrobson-WMF triaged this task as Medium priority.Fri, Feb 13, 11:36 PM
gerritbot added a comment.Fri, Feb 13, 11:54 PM

Change #1238760 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Refactor buildContentNavigationUrlsInternal

https://gerrit.wikimedia.org/r/1238760

gerritbot added a project: Patch-For-Review.Fri, Feb 13, 11:54 PM

Change #1239444 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Separate buildContentNavigationUrlsLinks from main function

https://gerrit.wikimedia.org/r/1239444

gerritbot added a comment.Fri, Feb 13, 11:54 PM

Change #1239445 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Separate buildContentNavigationUrlsVariants from function

https://gerrit.wikimedia.org/r/1239445

gerritbot added a comment.Sat, Feb 14, 12:40 AM

Change #1239449 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Separate buildContentNavigationUrlsActions from main function

https://gerrit.wikimedia.org/r/1239449

gerritbot added a comment.Sat, Feb 14, 12:40 AM

Change #1239450 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Separate buildContentNavigationUrlsViews from main function

https://gerrit.wikimedia.org/r/1239450

gerritbot added a comment.Sat, Feb 14, 12:40 AM

Change #1239451 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Separate buildContentNavigationUrlsAssociatedPages from main function

https://gerrit.wikimedia.org/r/1239451

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits