Page MenuHomePhabricator
Create Task
Maniphest T417513

Switch to CSS/JS solution for thumbnail size in legacy parser
Open, MediumPublic
Actions

Description

Parsoid is moving to a CSS/JS solution for thumbnail size (T375981); we probably want to use the same solution for the legacy parser as well to reduce the variance between legacy and Parsoid output.

TODO

  • Update legacy parser to support upscaling/downscaling of upright images
  • Wait 2 weeks (23rd April 2026)
  • Disable parser cache variance on thumbsize and apply Parsoid JavaScript and CSS to legacy parser

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Legacy parser no longer varies by thumbnail size.mediawiki/coremaster+8 -13
CSS thumbnail scaling: round 'upright' size to nearest 10pxmediawiki/coremaster+1 -1
Add upright CSS variable to legacy parsermediawiki/coremaster+18 -1
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Feb 15 2026, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2026, 9:29 PM
cscott mentioned this in T417514: Remove `thumbsize` from ParserOptions.Feb 15 2026, 9:29 PM
Mr._Starfleet_Command subscribed.Feb 16 2026, 1:17 AM
Jdlrobson-WMF moved this task from Backlog to Thumbnail simplification on the Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.Fri, Mar 13, 10:10 PM
Jdlrobson-WMF triaged this task as Medium priority.Tue, Mar 17, 12:09 AM
gerritbot added a comment.Fri, Mar 20, 10:32 PM

Change #1255907 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Legacy parser uses CSS to scale thumbnails

https://gerrit.wikimedia.org/r/1255907

gerritbot added a project: Patch-For-Review.Fri, Mar 20, 10:32 PM
Jdlrobson-WMF moved this task from Thumbnail simplification to Non-blockers on the Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.Fri, Mar 20, 10:53 PM
Jdlrobson-WMF mentioned this in T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.Thu, Mar 26, 11:20 PM
Jdlrobson-WMF mentioned this in T420657: Preferences settings for small image size are not compatible with upright for Parsoid Read Views.
Jdlrobson-WMF moved this task from Non-blockers to Tracking on the Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.Thu, Mar 26, 11:54 PM
Jdlrobson-WMF mentioned this in T376152: Evaluate feasibility of deprecating (or limiting) user media size preferences.Mon, Apr 6, 10:32 PM
Jdlrobson-WMF moved this task from WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views to For triage on the Readers Essential Work board.Tue, Apr 7, 11:37 PM
Jdlrobson-WMF edited projects, added Readers Essential Work; removed Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views).
Jdlrobson-WMF moved this task from For triage to Tracking on the Readers Essential Work board.Wed, Apr 8, 9:00 PM
gerritbot added a comment.Thu, Apr 9, 4:56 PM

Change #1269534 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] CSS thumbnail scaling: round 'upright' size to nearest 10px

https://gerrit.wikimedia.org/r/1269534

gerritbot added a comment.Thu, Apr 9, 5:06 PM

Change #1255907 merged by jenkins-bot:

[mediawiki/core@master] Add upright CSS variable to legacy parser

https://gerrit.wikimedia.org/r/1255907

gerritbot added a comment.Thu, Apr 9, 5:29 PM

Change #1269534 merged by jenkins-bot:

[mediawiki/core@master] CSS thumbnail scaling: round 'upright' size to nearest 10px

https://gerrit.wikimedia.org/r/1269534

Maintenance_bot removed a project: Patch-For-Review.Thu, Apr 9, 5:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Thu, Apr 9, 6:00 PM
gerritbot added a comment.Thu, Apr 9, 10:01 PM

Change #1269671 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Legacy parser no longer varies by thumbnail size.

https://gerrit.wikimedia.org/r/1269671

gerritbot added a project: Patch-For-Review.Thu, Apr 9, 10:01 PM
Jdlrobson-WMF updated the task description. (Show Details)Thu, Apr 9, 10:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits