Description
Details
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Don't vary ParserCache by thumbsize | C. Scott Ananian | mediawiki/core | master | +2 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T378089 [EPIC] Wikivoyages rollout followup work | |||
| Resolved | BUG REPORT | MSantos | T375981 Preferences settings for small image size are not being respected for Parsoid Read Views | ||
| Duplicate | BUG REPORT | None | T411414 Parsoid doesn't respect file thumbnail size setting | ||
| Resolved | Ladsgroup | T376152 Evaluate feasibility of deprecating (or limiting) user media size preferences | |||
| Open | Jdlrobson | T417514 Remove `thumbsize` from ParserOptions | |||
| Resolved | None | T424910 Limit Special:Preferences thumbnail option to three options - small, regular and large |
Event Timeline
Change #1255907 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] POC: Thumbnail size no longer varies parser cache
We still vary by thumbsize, right?
https://gerrit.wikimedia.org/g/mediawiki/core/+/1cbc0436501efa9ac93ea97dc51d42fa75640f8f/includes/Parser/ParserOptions.php#110
We are just not utilizing it.
I wuld consider this done when getThumbSize() and setThumbSize() no longer exist on ParserOptions ?
yes, sorry, I got confused about the final state of Add upright CSS variable to legacy parser (1255907) · Gerrit Code Review which had originally dropped that variable completely.
There are only two users in https://codesearch.wmcloud.org/deployed/?q=-%3EgetThumbSize%5C%28 -- probably the first step is to replace both with $userOptionsLookup->getDefaultOption( 'thumbsize' ), after which the parser cache won't vary by thumbsize because no one will ever call 'getOption('thumbsize')`. We can then deprecate and remove the method from ParserOptions.
Change #1300222 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] Don't vary ParserCache by thumbsize