Page MenuHomePhabricator
Create Task
Maniphest T417531

Section wrapping should use precise information about HTML-syntax headings
Open, LowPublic
Actions

Description

Parsoid doesn't add section edit links around HTML-syntax headings, and shortly (T417530) won't add <section> wrappers around HTML-syntax heading either.

For compatibility with the legacy parser we currently use the same heuristic which the legacy parser does: the presence of "extra" attributes on the <hX> tag. However Parsoid has precise information about the tag syntax in the data-parsoid, and the legacy parser could be extended to encode precise information as well, eg by adding a placeholder data-mw-wikitext-syntax attribute to headings generated from == ... == syntax.

This should be done after T417530: Parsoid shouldn't wrap wikitext html-ish `<hX>` tags in <section> wrappers if we find that there are significant numbers of "no attribute" html-syntax headings that are generating problematic <section> wrappers.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a26OSlegermediawiki/vendormaster+68 -3 K
Add `data-mw-wikitext` to wikitext-syntax headingsC. Scott Ananianmediawiki/services/parsoidmaster+16 -12
Update definition of html heading to match Parsoid/coreArlolramediawiki/extensions/DiscussionToolswmf/1.47.0-wmf.7+27 -13
Update definition of html heading to match Parsoid/coreArlolramediawiki/extensions/DiscussionToolsmaster+27 -13
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Feb 16 2026, 5:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2026, 5:48 AM
cscott mentioned this in T417530: Parsoid shouldn't wrap wikitext html-ish `<hX>` tags in <section> wrappers.Feb 16 2026, 5:49 AM
Izno subscribed.Feb 16 2026, 5:50 AM
Jdlrobson-WMF moved this task from Backlog to Non-blockers on the Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.Mar 13 2026, 10:11 PM
Jdlrobson-WMF triaged this task as High priority.Mar 26 2026, 11:53 PM
Jdlrobson-WMF lowered the priority of this task from High to Low.
Jdlrobson-WMF moved this task from Non-blockers to Tracking on the Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.
Jdlrobson-WMF moved this task from WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views to Tracking on the Readers Essential Work board.Apr 7 2026, 11:38 PM
Jdlrobson-WMF edited projects, added: Readers Essential Work; removed: Readers Essential Work (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views).
cscott added a comment.Jun 5 2026, 10:05 PM

Patch just merged, tagged with T68637: Make it possible to distinguish Wikitext headings and HTML headings.

cscott moved this task from Backlog to To Deploy on the Content-Platform-Team (Work In Progress) board.Jun 5 2026, 10:05 PM
ABreault-WMF assigned this task to cscott.Jun 12 2026, 3:41 PM
ABreault-WMF moved this task from To Deploy to To Verify on the Content-Platform-Team (Work In Progress) board.
gerritbot added a comment.Jun 15 2026, 6:56 PM

Change #1302237 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/DiscussionTools@master] [WIP] Update definition of html heading to match Parsoid/core

https://gerrit.wikimedia.org/r/1302237

gerritbot added a project: Patch-For-Review.Jun 15 2026, 6:56 PM
ExE-Boss subscribed.Jun 16 2026, 12:47 PM
gerritbot added a comment.Jun 16 2026, 4:38 PM

Change #1302237 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update definition of html heading to match Parsoid/core

https://gerrit.wikimedia.org/r/1302237

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2026, 5:32 PM
gerritbot added a comment.Jun 16 2026, 6:12 PM

Change #1302934 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/DiscussionTools@wmf/1.47.0-wmf.7] Update definition of html heading to match Parsoid/core

https://gerrit.wikimedia.org/r/1302934

gerritbot added a project: Patch-For-Review.Jun 16 2026, 6:12 PM
gerritbot added a comment.Jun 16 2026, 9:14 PM

Change #1302934 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.47.0-wmf.7] Update definition of html heading to match Parsoid/core

https://gerrit.wikimedia.org/r/1302934

Stashbot added a comment.Jun 16 2026, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-16T21:15:28Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1302934|Update definition of html heading to match Parsoid/core (T417530 T417531 T428677)]]

Stashbot mentioned this in T428677: Something is wrong with the rendering of headings on this page (due to new postprocessing of old parser cache entries).Jun 16 2026, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-16T21:17:23Z] <cscott@deploy1003> arlolra, cscott: Backport for [[gerrit:1302934|Update definition of html heading to match Parsoid/core (T417530 T417531 T428677)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2026, 9:31 PM
Stashbot added a comment.Jun 16 2026, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-16T21:34:10Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1302934|Update definition of html heading to match Parsoid/core (T417530 T417531 T428677)]] (duration: 18m 41s)

cscott mentioned this in T68637: Make it possible to distinguish Wikitext headings and HTML headings.Jun 19 2026, 12:05 PM
MSantos added a project: OKR-Work.Jul 9 2026, 1:20 PM
cscott merged a task: T68637: Make it possible to distinguish Wikitext headings and HTML headings.Aug 21 2026, 9:29 PM
cscott added subscribers: Patrick87, • matmarex, Taiwanese.Elephant and 6 others.
gerritbot added a comment.Aug 21 2026, 9:30 PM

Change #1302971 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Add `data-mw-wikitext` to wikitext-syntax headings

https://gerrit.wikimedia.org/r/1302971

gerritbot added a project: Patch-For-Review.Aug 21 2026, 9:30 PM
stjn unsubscribed.Aug 21 2026, 9:41 PM
cscott moved this task from To Verify to Code Review on the Content-Platform-Team (Work In Progress) board.Aug 21 2026, 10:10 PM

Moving back to code review, as https://gerrit.wikimedia.org/r/1302971 is still unmerged. (And even after it is merged, we might want to do some clean up before fully closing this task.)

Od1n unsubscribed.Aug 23 2026, 12:36 AM
gerritbot added a comment.Wed, Sep 30, 12:31 AM

Change #1302971 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add `data-mw-wikitext` to wikitext-syntax headings

https://gerrit.wikimedia.org/r/1302971

Maintenance_bot removed a project: Patch-For-Review.Wed, Sep 30, 1:31 AM
gerritbot added a comment.Mon, Oct 5, 3:53 PM

Change #1351383 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a26

https://gerrit.wikimedia.org/r/1351383

gerritbot added a project: Patch-For-Review.Mon, Oct 5, 3:53 PM
gerritbot added a comment.Mon, Oct 5, 7:16 PM

Change #1351383 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a26

https://gerrit.wikimedia.org/r/1351383

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 5, 7:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits