As seen in T338470#11622962 the Gerrit administrator user will still be gerrit2 after we're done with the task. We should harmonize this to avoid future confusion.
For the sake of naming harmonization, we should probably also rename the gerrit2 administrator account which will become more and more confusing after we finish changing the system user
@hashar wrote:
This is a Gerrit user account and is unrelated to the Unix user that got recently renamed from gerrit2 to gerrit (T338470). It is most probably an artifact of older Gerrit versions automatically creating an Admnistrator account based on the Unix name, but in practice they are disconnected.
From my comment on https://gerrit.wikimedia.org/r/c/operations/puppet/+/1243187/comments/d8bb063c_fec7bd19:
The hiera value is set to gerrit2:
hieradata/common/profile/gerrit.yaml profile::gerrit::service_account: 'gerrit2'That is used in:
modules/profile/manifests/gerrit.pp: String $service_account = lookup('profile::gerrit::service_account', { 'default_value' => 'gerrit2' }),And I stopped there. The variable is then used to craft ssh urls to port 29418 which are used to craft the configuration of the rename project plugin. It needs administrative rights in order to rename the repo, so that gerrit2 is indeed a different purpose :] Good catch, it should be left untouched for now.
We should create a new dedicated Service User for that purpose.