Page MenuHomePhabricator

"Assign labels" button at Special:EditWatchlist does not detect already selected checkboxes on page reload
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to https://test.wikipedia.org/wiki/Special:EditWatchlist
  • Make sure you have at least one watchlist label
  • Selected at least one page in the "Pages" list (if the list is empty, add any page to your watchlist first)
  • Reload the page and makes sure the page in the list is still selected
  • Click "Assign labels"

What happens?:

An error is displayed: "Please select the pages to which you would like to assign labels."

image.png (191×528 px, 18 KB)

This error should only be shown when no pages are selected.

What should have happened instead?:

No error should be shown and the dialog should allow the user to assign watchlist labels to the selected pages.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1239980 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] EditWatchlistDialog: Update selected pages list on page load

https://gerrit.wikimedia.org/r/1239980

Change #1239980 merged by jenkins-bot:

[mediawiki/core@master] EditWatchlistDialog: Update selected pages list on page load

https://gerrit.wikimedia.org/r/1239980

dom_walden subscribed.

I cannot reproduce this bug on testwiki.