Focus highlighting remains after focus has moved on in Filter menu
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Feb 18 2026, 3:53 PM

Project Tags

Referenced Files

	F72171138: highlight_remains.webm
	Feb 18 2026, 3:53 PM

Subscribers

Description

What is the problem?

When using the keyboard to navigate in the Filter menu, when an item gets focus it is highlighted but, when you move the focus, the highlighting remains.

This makes it hard to tell exactly which item is currently focused.

Steps to reproduce problem

https://en.wikipedia.beta.wmcloud.org/wiki/Special:RecentChanges
Open the Filter changes menu
Press the keyboard down/up buttons

Environment

Browser: Firefox 140. Chromium 145.
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.46.0-alpha (e28a421) 14:24, 18 February 2026.

Screenshots

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	rcfilters: Clear highlight before processing key navigation	Ypaula	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: rMWe28a42165058: REST Handler: Use absolute paths for response body schema files

Event Timeline

dom_walden created this task.Feb 18 2026, 3:53 PM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptFeb 18 2026, 3:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

PaulaYa subscribed.Feb 19 2026, 6:30 AM

I've reproduced this bug on both Chrome and Firefox. I'm interested in investigating a fix. Is it okay to work on this?

@PaulaYa

Yes it is ok to work on this. Thanks for picking this up and I look forward to reviewing your patch.

Change #1244641 had a related patch set uploaded (by Ypaula; author: Ypaula):

[mediawiki/core@master] rcfilters: Clear highlight before processing key navigation

https://gerrit.wikimedia.org/r/1244641

gerritbot added a project: Patch-For-Review.Feb 26 2026, 1:00 PM

Patch here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1244641
I think the fix is in the right place, but I wasn't able to test it locally. I would appreciate a second pair of eyes to confirm the approach makes sense!

In T417796#11654201, @PaulaYa wrote:

Patch here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1244641
I think the fix is in the right place, but I wasn't able to test it locally. I would appreciate a second pair of eyes to confirm the approach makes sense!

Sounds good, I'll move it to our kanban board for review.
Thank you for your work!

• Kgraessle moved this task from Code review requests to Kanban on the Moderator-Tools-Team board.Feb 26 2026, 1:10 PM

• Kgraessle edited projects, added: Moderator-Tools-Team (Kanban); removed: Moderator-Tools-Team.

• Kgraessle moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

• Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 2 2026, 11:09 AM

• Kgraessle moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 5 2026, 1:52 PM

DMburugu added a project: Essential-Work.Mar 9 2026, 12:04 PM

Dillon moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Mar 9 2026, 2:50 PM

Change #1244641 merged by jenkins-bot:

[mediawiki/core@master] rcfilters: Clear highlight before processing key navigation

https://gerrit.wikimedia.org/r/1244641

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2026, 3:30 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 9 2026, 4:00 PM

jsn.sherman closed this task as Resolved.Mar 11 2026, 6:33 PM

jsn.sherman claimed this task.

jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

Focus highlighting remains after focus has moved on in Filter menuClosed, ResolvedPublicBUG REPORTActions