- Open https://en.wikipedia.org/w/index.php?title=Pam_Hallandal&veaction=edit with the suggestions mode beta feature
- Observe the blockquote in "Work" is flagged for tone
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T265163 Create a system to encode best practices into editing experiences | |||
| Open | None | T365300 Introduce Edit Checks that encourage behavior aligned with Manual of Style consensus | |||
| Open | None | T365301 Tone Check: Prompt people to revise promotional language | |||
| Open | None | T416406 [MILESTONE] Offer Tone Check as default-on feature (all wikis) | |||
| Resolved | Esanders | T413026 [MILESTONE] Offer Tone Check as default-on feature at partner wikis | |||
| Resolved | Ryasmeen | T417801 ToneCheck should not run on block quotes |
Event Timeline
Comment Actions
We could get this by just setting ignoreQuotedContent in its defaults. Because it works on the paragraph level it'd mostly bypass the rest of the behavior (unless a paragraph opens with a quote-character), but the blockquote should get caught.
Comment Actions
It would be nice if we didn't do a pointless text search for quotation marks when we are checking an entire paragraph.
Comment Actions
Conveniently, it'll mostly short-circuit it. It first checks whether we're in a blockquote, and after that it walks from the start of the closest block node to the start of the range. Since the range in the tone check completely covers said block node, it should wind up with the search consisting of checking 0-1 items from the data model.
Comment Actions
Change #1240353 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@master] BaseEditCheck: fix check for blockquote
Comment Actions
Change #1240354 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@master] Tone check: ignore quoted content by default
Comment Actions
Change #1240353 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] BaseEditCheck: fix check for blockquote
Comment Actions
Change #1240361 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.16] BaseEditCheck: fix check for blockquote
Comment Actions
Change #1240354 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Tone check: ignore quoted content by default
Comment Actions
Change #1240361 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.16] BaseEditCheck: fix check for blockquote
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-02-18T21:27:09Z] <kemayo@deploy2002> Started scap sync-world: Backport for [[gerrit:1240361|BaseEditCheck: fix check for blockquote (T417801)]], [[gerrit:1239873|Add instrument for clicks in TOC references link (T415910)]], [[gerrit:1239877|Add instrument for clicks in footnotes in the article (T415909)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-02-18T21:29:21Z] <kemayo@deploy2002> kemayo, thiemowmde: Backport for [[gerrit:1240361|BaseEditCheck: fix check for blockquote (T417801)]], [[gerrit:1239873|Add instrument for clicks in TOC references link (T415910)]], [[gerrit:1239877|Add instrument for clicks in footnotes in the article (T415909)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-02-18T21:35:05Z] <kemayo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1240361|BaseEditCheck: fix check for blockquote (T417801)]], [[gerrit:1239873|Add instrument for clicks in TOC references link (T415910)]], [[gerrit:1239877|Add instrument for clicks in footnotes in the article (T415909)]] (duration: 07m 56s)