Page MenuHomePhabricator

Simplify sort options and getEntities in Special:ReadingLists Entries page
Closed, ResolvedPublic3 Estimated Story Points

Description

The getEntries method in Entries.vue handles many things, including sort options when the toolbar is enabled, which makes the code a bit complex.

  • Instead of an options property in the component, have named properties for each option: sort and dir.
  • Add method for onSortChanged which can handle refetching entities.
  • Make sortingText a computed property.
  • Remove this.total (it seems used just for when the sorting options change, to determine whether the list is empty or not).
  • Remove unused msgTotalArticles in special page.

Event Timeline

aude triaged this task as Medium priority.Feb 18 2026, 5:58 PM

Change #1240391 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/ReadingLists@master] Cleanup and implify getEntities in Entries.vue

https://gerrit.wikimedia.org/r/1240391

aude set the point value for this task to 3.Feb 24 2026, 3:29 PM
aude moved this task from Needs refinement to Ready for sprint on the Reader Experience Team board.

Change #1240391 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Cleanup and simplify getEntities in Entries.vue

https://gerrit.wikimedia.org/r/1240391

SToyofuku-WMF claimed this task.
SToyofuku-WMF subscribed.

^ I have no memory of moving this from QA :o

I've been asked to sign this off in lieu of Jan or Anne and the code looks good to me! Resolving