Page MenuHomePhabricator

Release version 0.1.15
Closed, ResolvedPublic16 Estimated Story Points

Description

NOTE: The items below should be done in sequence. I.e. 1. should be finished before starting on 2. etc.
  1. Make a patch with subject "Release version 0.1.15".
    1. Update CHANGES.md following the instructions under "On release".
    2. If the new version is greater than the snapshot: replace all @since tags for the new version with the correct one.
    3. Check that we haven't missed any @since tags that should be added or changed. To get all @since tags added from last version that have the wrong version number use this command, ex: git diff v0.1.14 | grep -P '^\+\s+\* @since (?!0\.1\.15)'
    4. Update extension.json to the latest version
    5. Check if any UI messages used for error audio (e.g. wikispeech-error-loading-audio-message) have changed. If so, regenerate corresponding audio files.
    6. Add any relevant information to the commit message.
  2. Make a tag for the new version:
    1. git tag v0.1.15
    2. git push --tags
  3. Update mw:Extension:Wikispeech
    • Change the download link for the latest version under Installation.
  4. Update mw:Help:Extension:Wikispeech
  5. Create a new task for next release. Copy the description of this one to get the correct formatting. Don't forget to change version number.
  6. Update Wikispeech to latest version on CloudVPS (producer & demo wiki)

Relevant tasks

Issues

Details

Related Changes in Gerrit:

Event Timeline

Wait until beginning of week 18 to do the release so that more things perhaps could come in.

I can't say that I understand how Phabricator is used to keep track of the status for the Wikispeech project parts/tasks.

The task "T395320: Make it easier to report pronunciation errors" was "closed as Resolved" by @Viktoria_Hillerud_WMSE five days ago?! The only forward reference or "trace into post mortem of the task" is that the task T395320 "is mentioned in T417886", i.e. in this task. That is why I write here rather than (try to) Reopen the "Make it easier"-task.
Please advice if there is a better place where you expect this type of feedback/error reports.

So, you state that the "Make it easier to report pronunciation errors"-task is "Resolved"!? To me, resolved means that the task has resulted in the expected outcome (or has been replaced by a new task or included in another task where "the story continues") but is that really the case here?
If the objective isn't possible to accomplish with available resources,
"Since we had issues making the backend work on the previous patch of this task, we chose to stick with a frontend solution."
the reason for closure should be more like "Rejected".

  • What are the concrete results, if any, from the Resolved task? What, if anything, has become easier?
  • What does that mean for the end user of Wikispeech?
  • What does that mean for the developer and maintainer of Wikispeech?
  • Where, in which task(s), are the remaining steps towards easier reporting planned and followed up?

Right now, when I click on the ...-button (More options, which is not translated to the user language) on the "Wikispeech toolbar" in svwiki, I get the following responses:

  1. A click on ? Visa hjälp (incorrectly) leads to, at least for me what about you?

https://sv.wikipedia.org/wiki/https://www.mediawiki.org/wiki/Special:MyLanguage/Help:%0AExtension:Wikispeech
On that page the title is "Felaktig titel" followed by Den begärda sidtiteln innehåller ogiltiga tecken; " ".
The line break character, i.e.%0A, seems wrong and should be removed.
Someone has somewhere incorrectly included a "\n" in the config setting for wgWikispeechHelpPage:

Also the https://sv.wikipedia.org/wiki/ at the start should be removed in order to reach the help page for Wikispeech. It looks like somewhere in the Wikispeech code an absolute url has been used as a relative url.

Looks like a similar "absolute versus relative url"-problem as for Rapportera uttalsfel, see below.

  1. A click on Rapportera uttalsfel (incorrectly) leads to, at least for me what about you?

https://sv.wikipedia.org/wiki/https://www.mediawiki.org/wiki/Extension_talk:Wikis%0Apeech
This is also a "Felaktig titel" page, but here the faulty line break character is placed in the middle of the word Wikispeech.
Someone has somewhere incorrectly included a "\n" in the config setting for wgWikispeechFeedbackPage:

If %0A and the https://sv.wikipedia.org/wiki/ is removed you end up at the English talk page for Wikispeech.

But is this really where you want the users to "Rapportera uttalsfel" for Swedish wikipedia pages?
Perhaps it is the page https://www.mediawiki.org/wiki/Extension:Wikispeech/Pronunciation_errors/sv that should be linked if it is still to be used, but I was under the impression that the ambition with the "Make it easier"-task was to replace that page with something better.

Just an observation, maybe irrelevant but related to the absolute/relative url issue mentioned above:
When I look in the config setting for pages in svwiki, i do find a value for wgWikispeechProducerUrl:

But I can't find any value for wgWikispeechReportPronunciationUrl
Is that correct or can it lead to problems in the execution of the PronunciationErrorDialog?

I noticed that comments have been added in the Status column on https://www.mediawiki.org/wiki/Extension:Wikispeech/Pronunciation_errors/sv but some of the comments are not easy to understand for the end user.

  • What does "Lagt till i syntesen" mean from the end user point of view?
  • When is the the corrected/improved pronunciation implemented and ready for verification?
  • "Detta är löst" sounds fine, but however not fully correct, "1:2" does still suffer from a pronunciation error".
  1. A click on Redigera lexikon (I guess correctly) leads to

https://wikispeech-producer.wmcloud.org/w/index.php?title=Special%3AEditLexicon&language=sv&page=9022147&consumerUrl=https%3A%2F%2Fsv.wikipedia.org%2Fw
This url does not include any line breaks and does not have the "relative addressing problem" like 1. and 2. but as I don't have the needed authority, the page just shows "Behörighetsfel" Du har inte behörighet att redigera Wikispeechs lexikon, av följande anledning:
Den åtgärd du har begärt kan enbart utföras av användare i gruppen: Wikispeech lexikon redaktörer.

This is however fine with me as I don't have any ambitions to edit the Wikispeech lexicon.

Let me end this long description with a suggestion that might be helpful to reduce confusion in references to Wikispeech in future error reporting:

  • Add an About alternative under More options on the Wikispeech toolbar where it is stated the exact version and configuration of the software that is active for the reporting end user at the reporting occasion. I guess there are several components, both server related, gadget/script related as well as user settings, that may be of interest for the person that tries to understand the exact environment/circumstances for a specific pronunciation error that is reported.

Thank you so much for your input. There are many insightful comments that will help improve Wikispeech. We will make sure to take them into account. To do that we will create tasks in the Wikispeech backlog corresponding to those. However, we will probably not be able to prioritize most of them for the time being as we are focusing our resources elsewhere, more exactly we are implementing a better TTS engine. With that said, it is still possible that someone from the community would choose to work on them.

We would be grateful if you could in the future write your findings in Extension talk:Wikispeech

Change #1284644 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):

[mediawiki/extensions/Wikispeech@master] Release version 0.1.15

https://gerrit.wikimedia.org/r/1284644

It looks like you forgot:

Update extension.json to the latest version

Yup I submitted the patchset but forgot to add it. Now its up!

Change #1284644 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Release version 0.1.15

https://gerrit.wikimedia.org/r/1284644

Only thing left now is to update our servers to the latest release, it will hopefully be up tomorrow afternoon.

Given the new requirements on both disk space and memory, we can't upgrade all three. There's should be enough resources to resize one of them to the next larger image, but then I think we hit the limit for at least memory.

My suggestion is to keep the test server at the size it is for now. It's running with only one Swedish voice to save on memory. This should work for the demo at the referensgruppsmöte.

Resize the demo server and upgrade with all voices supported. We'd have to test that the voices can all be loaded into the memory. If not we may want to disable some for the Begripsam tests.

If that works fine we still don't have enough resources to also resize the two remaining servers (test and producer). At this point we'd have to look at either merging two of the servers (probably demo and producer) or, if that doesn't work for some reason, request more resources for the project.

Sounds like a plan. The demo server is resized now, so I will start with downloading the release and then I will create a volume much like the utterance volume now attached to, and then hopefully, we can check out the new voices branch ahead of the begripsam tests