Page MenuHomePhabricator
Create Task
Maniphest T417994

DiscussionTools CommentModifierTest::testAddReplyLink test failure on PHP 8.4
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php84/197//console

00:03:03.126 There were 19 errors:
00:03:03.126 
00:03:03.126 1) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #2 ('plwiki oldparser', 'Wikipedia:Kawiarenka/Artykuły...iernik', 'cases/pl-big-oldparser/pl-big...r.html', 'cases/pl-big-oldparser/pl-big...y.html', '../data/plwiki-config.json', '../data/plwiki-data.json', false, false)
00:03:03.126 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.126 
00:03:03.126 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.126 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.126 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.126 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.126 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.126 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.126 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.127 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.127 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.127 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.127 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.127 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.127 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.127 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.128 
00:03:03.129 2) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #5 ('enwiki oldparser', 'Wikipedia:Village pump (techn...ve 175', 'cases/en-big-oldparser/en-big...r.html', 'cases/en-big-oldparser/en-big...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.129 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.129 
00:03:03.129 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.129 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.129 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.129 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.130 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.130 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.130 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.131 
00:03:03.131 3) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #8 ('arwiki no-paragraph oldparser', 'نقاش المستخدم:Khaled', 'cases/ar-no-paragraph-oldpars...r.html', 'cases/ar-no-paragraph-oldpars...y.html', '../data/arwiki-config.json', '../data/arwiki-data.json', false, false)
00:03:03.131 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.131 
00:03:03.131 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.131 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.131 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.131 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.132 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.132 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.132 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.132 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.133 
00:03:03.134 4) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #11 ('frwiki unsigned oldparser', 'Discussion:Le Monde', 'cases/fr-unsigned-oldparser/f...r.html', 'cases/fr-unsigned-oldparser/f...y.html', '../data/frwiki-config.json', '../data/frwiki-data.json', false, false)
00:03:03.134 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.134 
00:03:03.134 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.134 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.134 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.134 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.134 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.134 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.134 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.135 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.135 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.135 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.135 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.135 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.135 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.135 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.137 
00:03:03.137 5) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #14 ('itwiki unsigned oldparser', 'Aiuto:Sportello informazioni', 'cases/it-unsigned-oldparser/i...r.html', 'cases/it-unsigned-oldparser/i...y.html', '../data/itwiki-config.json', '../data/itwiki-data.json', false, false)
00:03:03.137 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.137 
00:03:03.137 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.137 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.137 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.137 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.138 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.138 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.138 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.138 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.139 
00:03:03.139 6) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #17 ('Double signature 1', 'Wikipedia:Requests for commen... names', 'cases/double-signature1/doubl...1.html', 'cases/double-signature1/doubl...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.139 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.139 
00:03:03.139 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.139 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.139 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.139 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.140 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.140 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.140 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.140 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.140 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.141 
00:03:03.141 7) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #23 ('Mess caused by unclosed <font...kitext', 'Overleg:Unclosed font', 'cases/unclosed-font/unclosed-font.html', 'cases/unclosed-font/unclosed-...y.html', '../data/nlwiki-config.json', '../data/nlwiki-data.json', false, false)
00:03:03.141 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.141 
00:03:03.141 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.141 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.141 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.141 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.141 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.141 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.142 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.142 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.142 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.142 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.142 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.142 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.142 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.142 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.143 
00:03:03.143 8) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #26 ('Reply inserted inside/outside...ements', 'Talk:Wrappers', 'cases/wrappers/wrappers.html', 'cases/wrappers/wrappers-forma...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.143 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.143 
00:03:03.143 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.144 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.144 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.144 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.144 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.144 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.144 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.145 
00:03:03.145 9) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #35 ('Signatures in funny places', 'Talk:Signatures funny', 'cases/signatures-funny/signat...y.html', 'cases/signatures-funny/signat...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.145 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.145 
00:03:03.145 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.145 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.146 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.146 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.146 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.146 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.146 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.147 
00:03:03.147 10) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #38 ('For parser cache', 'Talk:For parser cache', 'cases/for-parser-cache/for-pa...e.html', 'cases/for-parser-cache/for-pa...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.147 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.147 
00:03:03.147 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.148 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.148 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.148 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.148 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.148 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.148 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.149 
00:03:03.149 11) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #41 ('For parser cache (new)', 'Talk:For parser cache', 'cases/for-parser-cache-new/fo...w.html', 'cases/for-parser-cache-new/fo...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.149 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.149 
00:03:03.149 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.149 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.149 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.149 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.149 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.149 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.149 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.150 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.150 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.150 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.150 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.150 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.150 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.150 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.151 
00:03:03.151 12) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #44 ('tracked template', 'Commons talk:SPARQL query service', 'cases/tracked-template/tracke...e.html', 'cases/tracked-template/tracke...y.html', '../data/commonswiki-config.json', '../data/commonswiki-data.json', false, false)
00:03:03.151 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.151 
00:03:03.151 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.151 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.151 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.151 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.151 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.152 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.152 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.153 
00:03:03.153 13) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #47 ('Timestamp format switch behavior', 'Talk:T304595', 'cases/timestamp-format-switch...h.html', 'cases/timestamp-format-switch...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.153 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.153 
00:03:03.153 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.153 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.153 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.153 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.154 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.154 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.154 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.154 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.154 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.155 
00:03:03.155 14) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #50 ('Suppressed talk classes', 'User_talk:ESanders_(WMF)/supp...d-talk', 'cases/suppressed-talk/suppres...k.html', 'cases/suppressed-talk/suppres...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
00:03:03.155 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.155 
00:03:03.155 /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php:601
00:03:03.155 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:43
00:03:03.155 /workspace/src/includes/Html/HtmlHelperTrait.php:42
00:03:03.155 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
00:03:03.155 /workspace/src/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
00:03:03.155 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
00:03:03.155 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
00:03:03.156 /workspace/src/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
00:03:03.156 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
00:03:03.156 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
00:03:03.156 /workspace/src/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
00:03:03.156 /workspace/src/includes/Html/HtmlHelper.php:65
00:03:03.156 /workspace/src/extensions/DiscussionTools/includes/BatchModifyElements.php:28
00:03:03.156 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
Logs generated by test
00:03:03.157 
00:03:03.157 15) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #0 ('plwiki oldparser', 'Wikipedia:Kawiarenka/Artykuły...iernik', 'cases/pl-big-oldparser/pl-big...r.html', 'cases/pl-big-oldparser/pl-big...y.html', '../data/plwiki-config.json', '../data/plwiki-data.json')
00:03:03.157 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.157 
00:03:03.157 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
Logs generated by test
00:03:03.158 
00:03:03.158 16) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #1 ('enwiki oldparser', 'Wikipedia:Village pump (techn...ve 175', 'cases/en-big-oldparser/en-big...r.html', 'cases/en-big-oldparser/en-big...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json')
00:03:03.158 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.158 
00:03:03.158 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
Logs generated by test
00:03:03.159 
00:03:03.159 17) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #2 ('arwiki no-paragraph oldparser', 'نقاش المستخدم:Khaled', 'cases/ar-no-paragraph-oldpars...r.html', 'cases/ar-no-paragraph-oldpars...y.html', '../data/arwiki-config.json', '../data/arwiki-data.json')
00:03:03.159 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.159 
00:03:03.159 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
Logs generated by test
00:03:03.160 
00:03:03.160 18) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #3 ('frwiki unsigned oldparser', 'Discussion:Le Monde', 'cases/fr-unsigned-oldparser/f...r.html', 'cases/fr-unsigned-oldparser/f...y.html', '../data/frwiki-config.json', '../data/frwiki-data.json')
00:03:03.160 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.160 
00:03:03.160 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
Logs generated by test
00:03:03.161 
00:03:03.161 19) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #4 ('Signatures in funny places', 'Talk:Signatures funny', 'cases/signatures-funny/signat...y.html', 'cases/signatures-funny/signat...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json')
00:03:03.161 Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue
00:03:03.161 
00:03:03.161 /workspace/src/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
Logs generated by test
00:03:03.161

This is distinct from T415942: DiscussionTools CommentUtilsTest::testLinearWalk test failure on PHP 8.4 but also blocks CI enforcement of PHP 8.4, alas.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CommentFormatter: Fix compatibility with PHP 8.4mediawiki/extensions/DiscussionToolsREL1_45+4 -4
CommentFormatter: Fix compatibility with PHP 8.4mediawiki/extensions/DiscussionToolsmaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 20 2026, 2:30 PM
Restricted Application added a subscriber: hubaishan. · View Herald TranscriptFeb 20 2026, 2:30 PM
Jdforrester-WMF mentioned this in T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI.Feb 20 2026, 2:31 PM
Esanders subscribed.Feb 20 2026, 5:13 PM

According to the docs, $nodeValue is not readonly: https://www.php.net/manual/en/class.dom-htmlelement.php

Restricted Application added a subscriber: alaa. · View Herald TranscriptFeb 20 2026, 5:13 PM
Esanders added a subscriber: cscott.Feb 20 2026, 5:17 PM

cc @cscott

A_smart_kitten subscribed.Feb 20 2026, 6:03 PM

xref T413573: CI failures on PHP 8.4 from some core tests that call Parsoid's `DOMCompat::querySelector` method:

In T413573#11509656, @A_smart_kitten wrote:

Actually, a follow-up: I took a look at Codesearch (https://codesearch.wmcloud.org/deployed/?q=nodeValue&files=%5C.php for WMF-deployed code only); and, unfortunately, it seems like these failures relating to nodeValue might've been indicative of a wider backwards-compatibility problem.

To take DiscussionTools as a semi-random example from that Codesearch result:

$ composer phpunit:entrypoint -- extensions/DiscussionTools --filter "Comment(Formatter|Modifier)Test" --verbose
Using PHP 8.4.16
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.16
Configuration: /[...]/mediawiki/phpunit.xml.dist

.........E..E..E..E..E..E.....E..E........E..E..E..E..E..E.....  63 / 129 ( 48%)
................................EEEEE.......................... 126 / 129 ( 97%)
...                                                             129 / 129 (100%)

Time: 00:21.486, Memory: 88.50 MB

There were 19 errors:

1) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #2 ('plwiki oldparser', 'Wikipedia:Kawiarenka/Artykuły...iernik', 'cases/pl-big-oldparser/pl-big...r.html', 'cases/pl-big-oldparser/pl-big...y.html', '../data/plwiki-config.json', '../data/plwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

2) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #5 ('enwiki oldparser', 'Wikipedia:Village pump (techn...ve 175', 'cases/en-big-oldparser/en-big...r.html', 'cases/en-big-oldparser/en-big...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

3) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #8 ('arwiki no-paragraph oldparser', 'نقاش المستخدم:Khaled', 'cases/ar-no-paragraph-oldpars...r.html', 'cases/ar-no-paragraph-oldpars...y.html', '../data/arwiki-config.json', '../data/arwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

4) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #11 ('frwiki unsigned oldparser', 'Discussion:Le Monde', 'cases/fr-unsigned-oldparser/f...r.html', 'cases/fr-unsigned-oldparser/f...y.html', '../data/frwiki-config.json', '../data/frwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

5) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #14 ('itwiki unsigned oldparser', 'Aiuto:Sportello informazioni', 'cases/it-unsigned-oldparser/i...r.html', 'cases/it-unsigned-oldparser/i...y.html', '../data/itwiki-config.json', '../data/itwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

6) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #17 ('Double signature 1', 'Wikipedia:Requests for commen... names', 'cases/double-signature1/doubl...1.html', 'cases/double-signature1/doubl...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

7) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #23 ('Mess caused by unclosed <font...kitext', 'Overleg:Unclosed font', 'cases/unclosed-font/unclosed-font.html', 'cases/unclosed-font/unclosed-...y.html', '../data/nlwiki-config.json', '../data/nlwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

8) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #26 ('Reply inserted inside/outside...ements', 'Talk:Wrappers', 'cases/wrappers/wrappers.html', 'cases/wrappers/wrappers-forma...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

9) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #35 ('Signatures in funny places', 'Talk:Signatures funny', 'cases/signatures-funny/signat...y.html', 'cases/signatures-funny/signat...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

10) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #38 ('For parser cache', 'Talk:For parser cache', 'cases/for-parser-cache/for-pa...e.html', 'cases/for-parser-cache/for-pa...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

11) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #41 ('For parser cache (new)', 'Talk:For parser cache', 'cases/for-parser-cache-new/fo...w.html', 'cases/for-parser-cache-new/fo...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

12) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #44 ('tracked template', 'Commons talk:SPARQL query service', 'cases/tracked-template/tracke...e.html', 'cases/tracked-template/tracke...y.html', '../data/commonswiki-config.json', '../data/commonswiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

13) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #47 ('Timestamp format switch behavior', 'Talk:T304595', 'cases/timestamp-format-switch...h.html', 'cases/timestamp-format-switch...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

14) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #50 ('Suppressed talk classes', 'User_talk:ESanders_(WMF)/supp...d-talk', 'cases/suppressed-talk/suppres...k.html', 'cases/suppressed-talk/suppres...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/includes/CommentFormatter.php:601
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:43
/[...]/mediawiki/includes/Html/HtmlHelperTrait.php:42
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:289
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Serializer/Serializer.php:258
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/TreeBuilder.php:725
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/InBody.php:672
/[...]/mediawiki/vendor/wikimedia/remex-html/src/TreeBuilder/Dispatcher.php:434
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:619
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:406
/[...]/mediawiki/vendor/wikimedia/remex-html/src/Tokenizer/Tokenizer.php:214
/[...]/mediawiki/includes/Html/HtmlHelper.php:65
/[...]/mediawiki/extensions/DiscussionTools/includes/BatchModifyElements.php:28
/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentFormatterTest.php:142
=== Logs generated by test case
[...]
===

15) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #0 ('plwiki oldparser', 'Wikipedia:Kawiarenka/Artykuły...iernik', 'cases/pl-big-oldparser/pl-big...r.html', 'cases/pl-big-oldparser/pl-big...y.html', '../data/plwiki-config.json', '../data/plwiki-data.json')
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
=== Logs generated by test case
[...]
===

16) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #1 ('enwiki oldparser', 'Wikipedia:Village pump (techn...ve 175', 'cases/en-big-oldparser/en-big...r.html', 'cases/en-big-oldparser/en-big...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json')
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
=== Logs generated by test case
[...]
===

17) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #2 ('arwiki no-paragraph oldparser', 'نقاش المستخدم:Khaled', 'cases/ar-no-paragraph-oldpars...r.html', 'cases/ar-no-paragraph-oldpars...y.html', '../data/arwiki-config.json', '../data/arwiki-data.json')
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
=== Logs generated by test case
[...]
===

18) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #3 ('frwiki unsigned oldparser', 'Discussion:Le Monde', 'cases/fr-unsigned-oldparser/f...r.html', 'cases/fr-unsigned-oldparser/f...y.html', '../data/frwiki-config.json', '../data/frwiki-data.json')
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
=== Logs generated by test case
[...]
===

19) MediaWiki\Extension\DiscussionTools\Tests\CommentModifierTest::testAddReplyLink with data set #4 ('Signatures in funny places', 'Talk:Signatures funny', 'cases/signatures-funny/signat...y.html', 'cases/signatures-funny/signat...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json')
Error: Cannot modify readonly property Dom\HTMLElement::$nodeValue

/[...]/mediawiki/extensions/DiscussionTools/tests/phpunit/CommentModifierTest.php:90
=== Logs generated by test case
[...]
===

ERRORS!
Tests: 129, Assertions: 157, Errors: 19.

Granted that the Codesearch result linked above will probably have false-positives; but right now I'm feeling (at least) a bit concerned about the Parsoid and/or PHP backwards-compatibility break here (especially for parts of code that might not currently be covered by tests). cc @cscott

matmarex subscribed.Feb 20 2026, 11:06 PM

I think this is a bug in DiscussionTools, but there are also bugs (or intentional departures from the spec) in PHP.

We should be using textContent instead.

gerritbot added a comment.Feb 23 2026, 6:54 PM

Change #1242457 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/DiscussionTools@master] Fix compatibility with PHP 8.4

https://gerrit.wikimedia.org/r/1242457

gerritbot added a project: Patch-For-Review.Feb 23 2026, 6:54 PM
gerritbot added a comment.Feb 24 2026, 1:33 AM

Change #1242457 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix compatibility with PHP 8.4

https://gerrit.wikimedia.org/r/1242457

gerritbot added a comment.Feb 24 2026, 1:34 AM

Change #1242565 had a related patch set uploaded (by Paladox; author: Universal Omega):

[mediawiki/extensions/DiscussionTools@REL1_45] CommentFormatter: Fix compatibility with PHP 8.4

https://gerrit.wikimedia.org/r/1242565

gerritbot added a comment.Feb 24 2026, 1:51 AM

Change #1242565 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_45] CommentFormatter: Fix compatibility with PHP 8.4

https://gerrit.wikimedia.org/r/1242565

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Feb 24 2026, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 24 2026, 2:30 AM
matmarex closed this task as Resolved.Feb 24 2026, 3:22 AM
matmarex assigned this task to Universal_Omega.

Thanks for the patch!

matmarex mentioned this in T422031: Implement large/small buttons in OOUI.Tue, Apr 21, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits