Page MenuHomePhabricator
Create Task
Maniphest T418016

Banish circular refrences from Invariants
Closed, ResolvedPublic
Actions

Description

Description

Invariants points to an array of Evaluators, which themselves point back to Invariants 😬

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • no circles
  • only trees 😤

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-05-12-210548 to 2026-05-19-145724operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Feb 20 2026, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2026, 5:29 PM
cmassaro added a parent task: T413727: Validate and Productionize /v2/evaluate.Feb 20 2026, 5:29 PM
Jdforrester-WMF triaged this task as Medium priority.Feb 26 2026, 11:01 PM
Jdforrester-WMF added a project: OKR-Work.
Jdforrester-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
cmassaro edited parent tasks, added: T413840: Optimize composition language V2; removed: T413727: Validate and Productionize /v2/evaluate.Mar 4 2026, 6:45 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (26Q3 (Jan–Mar)).Apr 16 2026, 12:10 AM
Jdforrester-WMF subscribed.

This was tagged against Q3 because we thought it might get done during the v2 re-write; not complete, so moving up.

Jdforrester-WMF edited projects, added: Abstract Wikipedia Fix-It tasks; removed: OKR-Work.Apr 23 2026, 5:24 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF mentioned this in T426260: Split orchestrator's "invariants" object into actually-invariant OrchestratorConfig vs. call-specific RequestContext.May 13 2026, 8:44 PM
Jdforrester-WMF changed the task status from Open to In Progress.May 13 2026, 8:47 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (26Q4 (Apr–Jun)), Essential-Work; removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.May 13 2026, 8:53 PM
CodeReviewBot added a project: Patch-For-Review.May 13 2026, 9:01 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/665

Evaluator: Stop holding a back-pointer to Invariants

CodeReviewBot added a comment.May 13 2026, 11:24 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/666

Evaluator: Make various performance improvements Cory suggested last Quarter

CodeReviewBot added a comment.May 14 2026, 6:39 AM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/665

Evaluator: Stop holding a back-pointer to Invariants

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.May 14 2026, 12:33 PM
Jdforrester-WMF mentioned this in T413840: Optimize composition language V2.Fri, May 15, 12:45 PM
gerritbot added a comment.Tue, May 19, 3:11 PM

Change #1289373 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-05-12-210548 to 2026-05-19-145724

https://gerrit.wikimedia.org/r/1289373

gerritbot added a comment.Tue, May 19, 3:20 PM

Change #1289373 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-05-12-210548 to 2026-05-19-145724

https://gerrit.wikimedia.org/r/1289373

Jdforrester-WMF closed this task as Resolved.Tue, May 19, 3:23 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits