Page MenuHomePhabricator
Create Task
Maniphest T418138

Focused external link on mobile renders with incorrect icon placement
Closed, ResolvedPublic
Actions

Description

UnfocusedFocused
image.png (150×102 px, 2 KB)
image.png (150×102 px, 2 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (5cb0e8219)Esandersmediawiki/extensions/VisualEditormaster+9 -20
Replace link outline padding+margin hack with double box-shadowEsandersVisualEditor/VisualEditormaster+3 -5
Customize query in gerrit

Event Timeline

Esanders created this task.Feb 23 2026, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2026, 2:51 PM
gerritbot added a comment.Feb 23 2026, 3:14 PM

Change #1242418 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Replace link outline padding+margin hack with double box-shadow

https://gerrit.wikimedia.org/r/1242418

gerritbot added a project: Patch-For-Review.Feb 23 2026, 3:14 PM
PatchDemoBot added a comment.Feb 25 2026, 3:46 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://e9fe1d5be8.catalyst.wmcloud.org/w/

gerritbot added a comment.Feb 25 2026, 3:56 PM

Change #1242418 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Replace link outline padding+margin hack with double box-shadow

https://gerrit.wikimedia.org/r/1242418

gerritbot added a comment.Feb 26 2026, 11:24 AM

Change #1243867 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5cb0e8219)

https://gerrit.wikimedia.org/r/1243867

Esanders added a project: Essential-Work.Feb 26 2026, 11:25 AM
gerritbot added a comment.Feb 26 2026, 4:03 PM

Change #1243867 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5cb0e8219)

https://gerrit.wikimedia.org/r/1243867

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2026, 4:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Feb 26 2026, 5:00 PM
ppelberg added a project: Editing-team (Editing-18Feb-27Feb-2026).Feb 26 2026, 6:06 PM
ppelberg moved this task from Decisions to be made to Code Review on the Editing-team (Editing-18Feb-27Feb-2026) board.
ppelberg edited projects, added: Editing-team (Editing-2Mar-17Mar-2026); removed: Editing-team (Editing-18Feb-27Feb-2026).Mar 2 2026, 5:11 PM
ppelberg moved this task from Decisions to be made to Code Review on the Editing-team (Editing-2Mar-17Mar-2026) board.Mar 2 2026, 5:15 PM
DLynch assigned this task to Esanders.Mar 2 2026, 6:42 PM
DLynch moved this task from Code Review to QA on the Editing-team (Editing-2Mar-17Mar-2026) board.
ldelench_wmf triaged this task as High priority.Mar 2 2026, 6:42 PM
DLynch added a project: Editing QA.Mar 2 2026, 6:42 PM
ldelench_wmf closed this task as Resolved.Mar 2 2026, 6:43 PM
ldelench_wmf added a project: Skipped QA.
PatchDemoBot added a comment.Mar 12 2026, 9:30 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://e9fe1d5be8.catalyst.wmcloud.org/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits