Page MenuHomePhabricator

Inputs & Buttons: Consider updating sizing on mobile
Open, MediumPublic

Description

Background

Currently, in Codex, Inputs and Buttons do not increase their height on smaller screens. If T402344: Prototype Codex component expansion of font modes were done and font modes were implemented into the skins properly, and used, then they would scale with the changing of font mode, which would be inherent on mobile because Minerva would use a larger default [medium] than Vector [small].

However, this work is not currently prioritized, and we should still consider the responsive behavior for these components. We should explore updating the height of Inputs and Buttons on smaller screens. The heights should remain equivalent across components as they scale.

Acceptance criteria

  • Determine how to best increase the height of Inputs and Buttons on smaller screens
  • Update the height of Inputs and Buttons on smaller screens

Event Timeline

DTorsani-WMF moved this task from Backlog to In Progress on the Codex board.

Change #1245392 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] Inputs, Buttons: Increase height on smaller screens

https://gerrit.wikimedia.org/r/1245392

Change #1245392 abandoned by Dtorsani:

[design/codex@main] Inputs, Buttons: Increase height on smaller screens

Reason:

wrong git branch

https://gerrit.wikimedia.org/r/1245392

Change #1247136 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] Inputs, Buttons: Increase height on smaller screens

https://gerrit.wikimedia.org/r/1247136

Change #1247136 abandoned by Dtorsani:

[design/codex@main] Inputs, Buttons: Increase height on smaller screens

Reason:

Going to try taking a different approach to responsive inputs and buttons. This one proves to have bugs.

https://gerrit.wikimedia.org/r/1247136

Change #1321582 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] Button: Add `autoResponsive` prop

https://gerrit.wikimedia.org/r/1321582

Change #1325563 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] TextInput, SearchInput: Add size and responsiveness props

https://gerrit.wikimedia.org/r/1325563