Page MenuHomePhabricator

imageinfo API requests for DJVU files don't follow thumbnail steps, allows upscaling
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

{
  "continue": {
    "iistart": "2025-12-24T15:57:12Z",
    "continue": "||"
  },
  "query": {
    "pages": {
      "-1": {
        "ns": 6,
        "title": "File:A book of New England legends and folk lore in prose and poetry (bookofnewengla00drak 1910).djvu",
        "missing": "",
        "known": "",
        "imagerepository": "shared",
        "imageinfo": [
          {
            "thumburl": "https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu/page2-1024px-A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu.jpg",
            "thumbwidth": 1024,
            "thumbheight": 1553,
            "responsiveUrls": {
              "1.5": "https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu/page2-1536px-A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu.jpg",
              "2": "https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu/page2-2048px-A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu.jpg"
            },
            "url": "https://upload.wikimedia.org/wikipedia/commons/4/41/A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu",
            "descriptionurl": "https://commons.wikimedia.org/wiki/File:A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_(bookofnewengla00drak_1910).djvu",
            "descriptionshorturl": "https://commons.wikimedia.org/w/index.php?curid=180603038"
          }
        ]
      }
    }
  }
}

Trying 100px ends up with "https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu/page2-100px-A_book_of_New_England_legends_and_folk_lore_in_prose_and_poetry_%28bookofnewengla00drak_1910%29.djvu.jpg"

What should have happened instead?:
A thumbnail URL that follows T414805 and is no larger than the original file.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Atieno subscribed.

This is part of the current wider hypothesis under sre T414805 so moving this to Radar.

@Atieno Whilst SRE is driving WE 5.4.10, we do need support from other teams in P&T as appropriate to get this work done - Is the MW interfaces team not best placed to address this issue, please?

Change #1254365 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254365

Change #1254365 merged by jenkins-bot:

[mediawiki/core@master] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254365

Change #1254881 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@wmf/1.46.0-wmf.19] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254881

Change #1254884 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@wmf/1.46.0-wmf.20] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254884

Change #1254881 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.19] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254881

Change #1254884 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.20] DjvuHandler: Make it follow thumb steps

https://gerrit.wikimedia.org/r/1254884

Mentioned in SAL (#wikimedia-operations) [2026-03-18T11:55:39Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1254883|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254884|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]], [[gerrit:1254882|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254881|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]]

Mentioned in SAL (#wikimedia-operations) [2026-03-18T11:57:48Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1254883|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254884|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]], [[gerrit:1254882|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254881|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]] synced to the testservers (see https://wikitech.wikimedia.

Mentioned in SAL (#wikimedia-operations) [2026-03-18T12:02:27Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1254883|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254884|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]], [[gerrit:1254882|Make it follow thumb steps (T402792 T414805)]], [[gerrit:1254881|DjvuHandler: Make it follow thumb steps (T402792 T414805 T416620 T418178)]] (duration: 06m 48s)

Can someone also fix it for PDFHandler? PDF is used way more common than Djvu.

Can someone also fix it for PDFHandler? PDF is used way more common than Djvu.

PdfHandler was fixed more than a month ago https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PdfHandler/+/1240092 if something is not following it, it could be either caching or another bug.

So T420305 is not a duplicate of this? It is definitely not fixed today.

So T420305 is not a duplicate of this? It is definitely not fixed today.

Ah I took a look. It's the "iiurlparam" that overrides everything :( I suggest just setting the value that follows thumbs steps then. I'd honestly would deprecate that argument and replace it with "iipage" or something like that but no time.