| kostajh | |
| Feb 24 2026, 10:41 AM |
| F72503750: ta_vector_ltr.png | |
| Mar 4 2026, 1:52 PM |
| F72438712: screenshot.png | |
| Feb 26 2026, 5:00 PM |
| F72438676: screenshot.png | |
| Feb 26 2026, 4:56 PM |
| F72310379: image.png | |
| Feb 24 2026, 11:01 AM |
Temporary account usernames are not displayed in the personal tools / vector-menu-content section when using legacy Vector (and other skins that rely on SkinTemplate::addPersonalPageItem). This is because the method gates on $this->isNamedUser, which excludes temp users.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | STran | T417371 Replace/remove the gray bar temporary account holders | |||
| Resolved | kostajh | T418220 Legacy Vector: Show temporary account username in personal tools menu |
Change #1243071 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/core@master] Skin: Show temporary account username in personal tools
Change #1243072 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/skins/Vector@master] legacy: Show userTemporary icon for temp account usernames
Change #1243178 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/skins/MinervaNeue@master] Skin: Hide userpage for temp users in menus
Change #1243178 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Skin: Hide userpage for temp users in menus
Change #1243072 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Skin: Adjust personal tools for temporary users
Change #1243071 merged by jenkins-bot:
[mediawiki/core@master] Skin: Show temporary account username in personal tools
As a result of this patch, the top-toolbar in V2010 looks like the following when using a temporary account for me (repro'd locally & on a blank Patch Demo):
 |
I just want to check if this was intentional, as FWICS it differs slightly from the design in T418220#11644381 (which doesn't seem to include the 'Create account' link after the temp-account's username).
edit: screenshot changed to the correct one; wording
As a result of this patch, the top-toolbar in V2010 looks like the following when using a temporary account for me (repro'd locally & on a blank Patch Demo):
I just want to check if this was intentional, as FWICS it differs slightly from the design in T418220#11644381 (which doesn't seem to include the 'Create account' link after the temp-account's username).
edit: screenshot changed to the correct one; wording
Yes, it is intentional (cc @KieranMcCann-WMF)
@A_smart_kitten Yes, it was intentional as we decided it would be useful to surface the ‘Create account’ link close to the temp account username.
Should we revert https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1243072 ?
We don't show temporary accounts in Wikimedia production to legacy Vector skin and don't support using non-default skins for temporary accounts so this code supports third parties and is not being actively tested.
I don't see why that should lead to a revert though? Even if it's not being actively tested, it should be fine to leave as-is with the idea that the skin isn't guaranteed to work with temporary accounts?
We often make changes to menus to support Vector 2022 and Minerva. Given the approach taken in the patch (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1243072/7/includes/SkinVectorLegacy.php) the order cannot be guaranteed as stable.
I'm fine with keeping as is if we are okay with things like menu items changing ordering, but I don't want to give a false expectation it is "Active WMF Development" <1>and it will always work the way it currently does.
I see this is marked as "Done" but not resolved. Anything left?
