Page MenuHomePhabricator

onBranchNodeChange should fire when branch node type is modified
Closed, ResolvedPublic

Description

  1. Open https://en.wikipedia.org/w/index.php?title=Pam_Hallandal&veaction=edit&section=4
  2. Place your cursor in the block quote, then remove the blockquote using the format menu

Expected: A Tone Check should appear
Observed: Nothing happens until you move paragraph

This is more jarring when going the other way:
Paste in a large tone-violating paragraph and you will trigger ToneCheck and PasteCheck. Marking the paragraph as a block quote should instantly resolve both these, but instead you need to move the cursor for checks to re-run.

Event Timeline

Change #1244608 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck controller: Don't fire branchNodeChange if no changes made

https://gerrit.wikimedia.org/r/1244608

Change #1244608 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck controller: Don't fire branchNodeChange if no changes made

https://gerrit.wikimedia.org/r/1244608

DLynch added a project: Skipped QA.
DLynch subscribed.

This kind of caused T420222, though it's more accurate to say it exposed an underlying return-type issue.