ButtonExample.php contains examples of various types of buttons, but there aren't any with the size set to "large" or the weight set to "quiet".
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | LGoto | T417438 Projects and mentors for Wikimedia Outreachy Round 32 | |||
| Declined | None | T418023 Outreachy 32: Vector 2022 Codex PHP migration | |||
| Declined | Vanny | T418281 Codex-PHP: Add examples of large, quiet buttons to ButtonExample |
Change #1257482 had a related patch set uploaded (by Rishan; author: Rishan):
[design/codex-php@main] OUTREACHY-T418281:added examples of large, quiet buttons to ButtonExample
Change #1257993 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):
[design/codex-php@main] T418281: Added examples of large and quiet buttons to ButtonExample
Hiie, Eileen here.
I have added examples of large and quiet buttons to ButtonExample.php. The patch can be found here: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257993
Change #1257993 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):
[design/codex-php@main] sandbox: Add examples of large and quiet buttons to ButtonExample
Change #1258163 had a related patch set uploaded (by ItoroJames; author: ItoroJames):
[design/codex-php@main] ButtonExample: Add large and quiet button examples
Hi, I've submitted a patch for this task:
https://gerrit.wikimedia.org/r/c/design/codex-php/+/1258163
Added large and quiet button examples to ButtonExample.php and
removed the now-redundant snapshot tests for those variants from
SnapshotTest.php. Updated snapshots accordingly.
Change #1257482 had a related patch set uploaded (by Rishan; author: Rishan):
[design/codex-php@main] Sandbox:Added examples of large, quiet buttons to ButtonExample
Change #1260114 had a related patch set uploaded (by Ajimbong; author: Ajimbong):
[design/codex-php@main] ButtonExample: Add large and quiet button example, and remove the corresponding large and quiet button tests in SnapshotTests.php
Hello, I have submitted a patch for this task at: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1260114
I added the large and quiet buttons, and updated SnapshotTests.php so it won't cover the large and quiet buttons during the snapshot tests.
(bonus:) Remove the corresponding large and quiet button tests in SnapshotTests.php
I am not sure if I interpreted this^ task correctly, but I would appreciate any feedback on it.
Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.
Change #1260114 abandoned by VolkerE:
[design/codex-php@main] ButtonExample: Add large and quiet button example, and remove the corresponding large and quiet button tests in SnapshotTests.php
Reason:
Thanks for your contribution. We're going ahead with another candidate's patch, for reference: Ia5fe25ee3b6
This was a good quality patch, the other candidate was a bit faster in starting the task. Best regards nonetheless!
Change #1258163 abandoned by Catrope:
[design/codex-php@main] ButtonExample: Add large and quiet button examples
Reason:
Done in https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257993
Change #1257482 abandoned by Catrope:
[design/codex-php@main] Sandbox: Added examples of large, quiet buttons to ButtonExample
Reason:
Abandoning this patch in favor of https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257993 , which is almost the same but a little cleaner and also adds a small button
Change #1257993 merged by jenkins-bot:
[design/codex-php@main] sandbox: Add examples of small, large and quiet buttons to ButtonExample