Page MenuHomePhabricator

Revise Tone: scrolling on desktop
Open, HighPublic

Description

In T416537, we fixed an issue wherein people who tapped a Revise Tone structured task from within the newcomer homepage on mobile landed in VE without the Revise Tone card, and its related content, being scrolled into someone's view.

This ticket involves the work of addressing the same issue that seems to have cropped up and/or remained unaddressed on desktop.

Steps to replicate the issue (include links if applicable):

  • On a desktop device
  • Open the Homepage (and ensure you are opted into the Revise Tone task)
  • Navigate to a Revise Tone task

What happens?:

  • Notice that you often don't automatically get scrolled down to have the edit check actually in view.

Example: https://youtu.be/NcsQo6tII6M

What should have happened instead?:

  • The Edit Check card should display by default AND the paragraph with the Edit Check present should be visible on screen.

Possibly related bug: T411367: Page scrolls to the very top on a small scroll up gesture

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael added a subscriber: Etonkovidova.

Thank you for creating this and picking it up! 💚 I'll keep an eye on it and also added @Etonkovidova

This used to work at some point. We should find also find a way to write a robust test for this.

Is this still an issue, or did we fix it with all our other recent scrolling changes?

I think this is still an issue.

I just did some testing on desktop. For the 5 articles I tested I was scrolled down to approximately the right area, but often part of the Revise Tone edit check card was cut off.

Screenshot 2026-03-10 at 3.44.00 PM.png (1×3 px, 1 MB)

Screenshot 2026-03-10 at 3.45.40 PM.png (1×3 px, 859 KB)

@Etonkovidova do you notice the same behavior?

Screenshot 2026-03-10 at 3.47.13 PM.png (1×3 px, 939 KB)

The edit notice also occasionally overlaps with the Edit Check card. Should I log a separate bug for that? It looks like it wouldn't overlap if it was actually aligned with the Edit Notice icon.

@JVanderhoop-WMF also shared some feedback that she noticed "some funky navigation and scrolling behaviours" when testing Revise Tone. (Although she was testing on mobile, and this task is about desktop). But I do get the sense that there are still some issues with scrolling on both desktop and mobile.

The edit notice also occasionally overlaps with the Edit Check card. Should I log a separate bug for that? It looks like it wouldn't overlap if it was actually aligned with the Edit Notice icon.

Yeah, file a separate bug for that. It's really a general edit-check bug with us not relocating the popup when the toolbar is resized.

(removing my non-work phab account from subscribers)

Change #1251564 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] ReviseTone: make scroll align to top when opening check

https://gerrit.wikimedia.org/r/1251564

Yeah, file a separate bug for that. It's really a general edit-check bug with us not relocating the popup when the toolbar is resized.

Also, I think we may have fixed it incidentally as a side-effect of some changes we made to general visualeditor toolbar rendering. I can't persuade it to trigger any more, at least.

Change #1253741 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/GrowthExperiments@master] ReviseTone: scroll down to relevant content on desktop

https://gerrit.wikimedia.org/r/1253741

Change #1251564 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ReviseTone: make scroll align to top when opening check on desktop

https://gerrit.wikimedia.org/r/1251564

Change #1253741 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ReviseTone: scroll down to relevant content on desktop

https://gerrit.wikimedia.org/r/1253741