Page MenuHomePhabricator

Codex-PHP: Add examples of selected, disabled and inline Radio
Closed, DeclinedPublic

Description

RadioExample.php contains one example of a radio button. We should make this a group of radio buttons that demonstrates different types of radio buttons.

  • Add a radio button that is already selected
  • Add a disabled radio button
  • Add an inline radio button
  • Verify that they show up correctly in the sandbox (composer run-script start-sandbox)
  • Regenerate the snapshot tests (composer run update-snapshots)

Event Timeline

Hi, I would like to work on this ticket

Change #1257245 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] OUTREACHY-T418301:Codex-PHP: Add examples of selected, disabled and inline Radio

https://gerrit.wikimedia.org/r/1257245

Change #1258022 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] T418301: Add examples of selected, disabled and inline Radio

https://gerrit.wikimedia.org/r/1258022

I have added examples of selected, disabled and inline radio buttons to RadioExample.php. The patch can be found here: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1258022

Change #1258022 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] sandbox: Add examples of selected, disabled and inline Radio

https://gerrit.wikimedia.org/r/1258022

Change #1257245 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] Add examples of selected, disabled, and inline Radio

https://gerrit.wikimedia.org/r/1257245

Change #1257245 had a related patch set uploaded (by Vanessa_bedzra; author: Vanessa_bedzra):

[design/codex-php@main] T418301:Add examples of selected, disabled, and inline Radio

https://gerrit.wikimedia.org/r/1257245

Change #1258134 had a related patch set uploaded (by ItoroJames; author: ItoroJames):

[design/codex-php@main] T418301: Add examples of selected, disabled and inline Radio

https://gerrit.wikimedia.org/r/1258134

Hi, I've submitted a patch for this task:
https://gerrit.wikimedia.org/r/c/design/codex-php/+/1258134

Added selected, disabled and inline Radio examples to RadioExample.php
and regenerated snapshot tests.

Change #1260042 had a related patch set uploaded (by Ajimbong; author: Ajimbong):

[design/codex-php@main] RadioExample: Add checked radio button and inline radio button.

https://gerrit.wikimedia.org/r/1260042

Hello, I have submitted a patch for this task: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1260042

I added the selected, disabled and inline Radio button examples, and generated snapshot tests.

Change #1260090 had a related patch set uploaded (by Rishan; author: Rishan):

[design/codex-php@main] Radio: Added examples of selected, disabled and inline Radio

https://gerrit.wikimedia.org/r/1260090

LGoto subscribed.

Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.

Change #1258022 abandoned by VolkerE:

[design/codex-php@main] sandbox: Add examples of selected, disabled and inline Radio

Reason:

We'll go here with Ic89f2879b6a36077 instead, as the other patch is equally good, but the contributor was a bit faster. Thanks again!

https://gerrit.wikimedia.org/r/1258022

Change #1260090 abandoned by VolkerE:

[design/codex-php@main] Radio: Added examples of selected, disabled and inline Radio

Reason:

Thanks for your contribution. The output here was good. We went with another patch nonetheless, which was contributed earlier and is building on top of the newer API. Best regards nonetheless!

https://gerrit.wikimedia.org/r/1260090

Change #1257245 merged by jenkins-bot:

[design/codex-php@main] sandbox: Add examples of selected, disabled, and inline Radio

https://gerrit.wikimedia.org/r/1257245