Page MenuHomePhabricator

Codex-PHP: Add examples of checked, disabled and inline Checkbox
Closed, DeclinedPublic

Description

CheckboxExample.php contains one example of a checkbox. We should make this a group of checkboxes that demonstrates different types of checkboxes.

  • Add a checkbox that is already checked
  • Add a disabled checkbox
  • Add an inline checkbox
  • Verify that they show up correctly in the sandbox (composer run-script start-sandbox)
  • Regenerate the snapshot tests (composer run update-snapshots)

Event Timeline

Catrope updated the task description. (Show Details)

Change #1257202 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] T418302: Added the already checked, disabled and inline Checkboxes

https://gerrit.wikimedia.org/r/1257202

Hiieee, I'm Eileen. I have submitted a patch for this task. Please find it here: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257202

Change #1258139 had a related patch set uploaded (by ItoroJames; author: ItoroJames):

[design/codex-php@main] T418302: Add examples of checked, disabled and inline Checkbox

https://gerrit.wikimedia.org/r/1258139

Hi, I've submitted a patch for this task:
https://gerrit.wikimedia.org/r/c/design/codex-php/+/1258139

Added checked, disabled and inline Checkbox examples to CheckboxExample.php
and regenerated snapshot tests.

Change #1260065 had a related patch set uploaded (by Ajimbong; author: Ajimbong):

[design/codex-php@main] CheckboxExample: Add checked, disabled and inline checkbox

https://gerrit.wikimedia.org/r/1260065

Change #1257202 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] sandbox: Add the checked, disabled and inline Checkboxes

https://gerrit.wikimedia.org/r/1257202

Volker_E subscribed.

@Androgenius-codes un-assigning you. Not sure, if you've provided a patch under a different name, it's hard to identify from Wikimedia point of view.

LGoto subscribed.

Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.

Change #1257202 merged by jenkins-bot:

[design/codex-php@main] sandbox: Add the checked, disabled and inline Checkboxes

https://gerrit.wikimedia.org/r/1257202

Change #1260065 abandoned by VolkerE:

[design/codex-php@main] CheckboxExample: Add checked, disabled and inline checkbox

Reason:

This was a pretty good approach to the problem. We went ahead with I4a4270e937278463 instead as other candidate was first and resolved all inputs timely. Use theirs as reference. Thanks again!

https://gerrit.wikimedia.org/r/1260065