Page MenuHomePhabricator

Codex-PHP: Add an example of a Card without a URL set
Closed, DeclinedPublic

Description

CardExample.php contains an example of a Card that is clickable (has a URL set). Add an example of a Card that is not clickable (does not have a URL set).

  • Add an example Card without a URL
  • Verify that it shows up correctly in the sandbox (composer run-script start-sandbox)
  • Regenerate the snapshot tests (composer run update-snapshots)

Event Timeline

Change #1257103 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] T418303: Added example of Card without URL set

https://gerrit.wikimedia.org/r/1257103

Hi there, I have completed all three steps for this task. The patch can be found here: https://gerrit.wikimedia.org/r/c/design/codex-php/+/1257103

Ddshelto subscribed.

Change #1258123 had a related patch set uploaded (by ItoroJames; author: ItoroJames):

[design/codex-php@main] T418303: Add example of Card without URL set

https://gerrit.wikimedia.org/r/1258123

Hi, I've submitted a patch for this task:
https://gerrit.wikimedia.org/r/c/design/codex-php/+/1258123

Added a non-clickable Card example to CardExample.php and regenerated snapshot tests.

Change #1259131 had a related patch set uploaded (by Ajimbong; author: Ajimbong):

[design/codex-php@main] CardExample: Add CardExample without a URL

https://gerrit.wikimedia.org/r/1259131

LIZ254 set Due Date to Apr 15 2026, 12:00 AM.
Aklapper removed Due Date which was set to Apr 15 2026, 12:00 AM.
Aklapper added a subscriber: LIZ254.

Change #1260003 had a related patch set uploaded (by Rishan; author: Rishan):

[design/codex-php@main] Card: Add example of a Card without URL

https://gerrit.wikimedia.org/r/1260003

Change #1257103 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):

[design/codex-php@main] sandbox: Add example of Card without URL set

https://gerrit.wikimedia.org/r/1257103

Change #1265370 had a related patch set uploaded (by Chimaobi98; author: Chimaobi98):

[design/codex-php@main] CardExample: Add example of a Card without a URL set

https://gerrit.wikimedia.org/r/1265370

LGoto subscribed.

Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.

Change #1257103 merged by jenkins-bot:

[design/codex-php@main] sandbox: Add example of Card without URL set

https://gerrit.wikimedia.org/r/1257103

Change #1265370 abandoned by VolkerE:

[design/codex-php@main] CardExample: Add example of a Card without a URL set

Reason:

This was a pretty good approach to the problem. We went ahead with Ia64a5af9c4b05 instead as other candidate was first and resolved all inputs timely. Use theirs as reference. Thanks again!

https://gerrit.wikimedia.org/r/1265370

Change #1260003 abandoned by VolkerE:

[design/codex-php@main] Card: Add example of a Card without URL

Reason:

This was a pretty good approach to the problem. We went ahead with Ia64a5af9c4b05 instead as other candidate was first and resolved all inputs timely. Use theirs as reference. Thanks again!

https://gerrit.wikimedia.org/r/1260003

Change #1259131 abandoned by VolkerE:

[design/codex-php@main] CardExample: Add CardExample without a URL

Reason:

This was a pretty good approach to the problem. We went ahead with Ia64a5af9c4b05 instead as other candidate was first and resolved all inputs timely. Use theirs as reference. Thanks again!

https://gerrit.wikimedia.org/r/1259131