There are several instances of hard-coded Codex Messages in WebInstaller.php, where the code generates <div class="cdx-message"> blocks; for example, here. Convert these to use Codex-PHP. See MessageExample.php for an example of how to use Codex-PHP to render a Message.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | LGoto | T417438 Projects and mentors for Wikimedia Outreachy Round 32 | |||
| Declined | None | T418023 Outreachy 32: Vector 2022 Codex PHP migration | |||
| Declined | Androgenius-codes | T418307 Convert hard-coded uses of cdx-message in WebInstaller to Codex-PHP |
Event Timeline
Comment Actions
Change #1257498 had a related patch set uploaded (by Androgenius; author: Androgenius):
[mediawiki/core@master] WebInstaller: Replace hard-coded cdx-message HTML with Codex-PHP
Comment Actions
I have submitted a patch for this task. You can find it here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1257498. looking forward to the review
Comment Actions
Change #1257519 had a related patch set uploaded (by Rishan; author: Rishan):
[mediawiki/core@master] [OUTREACHY]-T418307:Convert hard-coded uses of cdx-message in WebInstaller to Codex-PHP
Comment Actions
Change #1258152 had a related patch set uploaded (by Rishan; author: Rishan):
[mediawiki/core@master] WebInstaller: update hard-coded cdx-message to use Codex-PHP
Comment Actions
Change #1258152 abandoned by Rishan:
[mediawiki/core@master] WebInstaller: update hard-coded cdx-message to use Codex-PHP
Reason:
duplicate
Comment Actions
Change #1258160 had a related patch set uploaded (by Rishan; author: Rishan):
[mediawiki/core@master] WebInstaller: update hard-coded cdx-message to use Codex-PHP
Comment Actions
Change #1258160 abandoned by Rishan:
[mediawiki/core@master] WebInstaller: update hard-coded cdx-message to use Codex-PHP
Reason:
duplicate
Comment Actions
Change #1257519 had a related patch set uploaded (by Rishan; author: Rishan):
[mediawiki/core@master] WebInstaller: Update hard-coded cdx-message to use Codex-PHP
Comment Actions
Change #1259988 had a related patch set uploaded (by ItoroJames; author: ItoroJames):
[mediawiki/core@master] installer: Convert hard-coded cdx-message to Codex-PHP
Comment Actions
I have submitted a patch for this task. You can find it here:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1259988
Replaces hard-coded CDX message HTML with Codex-PHP Message component
when available, with fallback to original HTML for compatibility.
- Added getCodex() method to lazy-load Codex from service container
- Converted showMessage(), showWarning(), showSuccess()
- Converted getInfoBox(), getHelpBox()
- Added fallback to original HTML if Codex unavailable
Looking forward to the review
Comment Actions
Can I ask why we've got 3 different people submitting patches for the same thing in a few days? One person has claimed it already...
Comment Actions
Change #1263060 had a related patch set uploaded (by EileenBlessing; author: EileenBlessing):
[mediawiki/core@master] installer: Use Codex-PHP to render messages in WebInstaller
Comment Actions
Thanks to all the candidates who showed an interest in this project. Unfortunately, due to changing circumstances, the mentor team is no longer able to move forward with this project proposal. We appreciate all the work that’s been put into this already, and wish all the candidates the best in your future work.
Comment Actions
Change #1259988 abandoned by VolkerE:
[mediawiki/core@master] installer: Convert hard-coded cdx-message to Codex-PHP
Reason:
Abandoned for I3e031053d86f1, b/c it fulfills the task as current one, but was provided days earlier.
Comment Actions
Change #1257519 abandoned by VolkerE:
[mediawiki/core@master] WebInstaller: Update hard-coded cdx-message to use Codex-PHP
Reason:
Thanks for your contribution, another volunteer has provided their contribution slightly earlier at about the same quality. So we go with theirs instead: I3e031053d86f1cbc