Page MenuHomePhabricator

EditCheck: On mobile, a check should only become "active" when it is visible
Closed, ResolvedPublic

Description

Whenever a cursor is placed in a check, the selection changes colour to indicate it is "active". On desktop this makes sense as moving the selection causes the check card to be expanded and become "active".

On mobile, the check remains hidden until you click the icon in the gutter, but we still consider it "active" and change the colour of the selection. We should not consider a check "active" until it is visible.

Check has cursor, not visibleCheck is visible
Current
image.png (412×710 px, 99 KB)
image.png (412×710 px, 98 KB)
Proposed
image.png (412×710 px, 101 KB)
image.png (412×710 px, 98 KB)
(unchanged)

Note that on a real device, the check having a cursor would likely show the virtual keyboard as well.

Event Timeline

Change #1247587 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Only show action as focused on mobile when visible

https://gerrit.wikimedia.org/r/1247587

Change #1247587 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Only show action as focused on mobile when visible

https://gerrit.wikimedia.org/r/1247587

EAkinloose edited projects, added: Verified; removed: Editing QA.