Page MenuHomePhabricator

Fix cross wiki auto close trigger
Closed, ResolvedPublic

Description

Summary

The auto-close jobs are not fired when a user is globally banned on a wiki that doesn't have that user locally present.

Technical instructions:

When a global block is created from a wiki where the target user has no local account (i.e. $targetUser->getId() === 0 on that wiki), the onGlobalBlockingGlobalBlockAudit hook handler returns early, and no auto-close jobs are dispatched at all — including the CrossWikiJobDispatcher that would enqueue jobs on wikis where the user does exist.

Event Timeline

Change #1244596 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CheckUser@master] Fix cross-wiki dispatch skipped for users with no local account

https://gerrit.wikimedia.org/r/1244596

Change #1244596 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix cross-wiki dispatch skipped for users with no local account

https://gerrit.wikimedia.org/r/1244596

dom_walden subscribed.

I no longer see this bug. There is an issue of cases not being closed if the user does not exist on the wiki which has the case. I don't know if this is a problem or not.

Dreamy_Jazz updated the task description. (Show Details)