I guess that the risk is that we'd need the design to cope with potentially quite large amounts of text, particularly if we roll out the regex replacements feature.

In T418470#11655199, @DLynch wrote:

I guess that the risk is that we'd need the design to cope with potentially quite large amounts of text, particularly if we roll out the regex replacements feature.

We can ignore matches/replacements above N characters for now - so this will still work for 99% of cases.

Change #1251014 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: Show specific replacement about to take place

https://gerrit.wikimedia.org/r/1251014

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://e26e154d4b.catalyst.wmcloud.org/wiki/Main Page?veaction=edit&ecenable=2

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://5761f14346.catalyst.wmcloud.org/wiki/Main Page?veaction=edit&ecenable=2

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://8e905181a5.catalyst.wmcloud.org/wiki/Regent's Park?veaction=edit&ecenable=experimental,suggestions

We could use the question above the buttons (the one we use in Paste Check) to show the suggested word and ask the user to replace it.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://e26e154d4b.catalyst.wmcloud.org/w/

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://5761f14346.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://12b02df0a4.catalyst.wmcloud.org/wiki/Regent's Park?veaction=edit&ecenable=experimental,suggestions

In T418470#11709569, @bmartinezcalvo wrote:

We could use the question above the buttons (the one we use in Paste Check) to show the suggested word and ask the user to replace it.

@bmartinezcalvo: what you proposed here looks like a nice incremental improvement. And @Esanders, it looks like the PatchDemo you created implements it. [1]

Next steps
All of the above leads me to think the next step here is code review. If you're seeing this differently, please let me know. In the meantime, I'm moving it there on the upcoming sprint board.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://8e905181a5.catalyst.wmcloud.org/w/

In T418470#11709569, @bmartinezcalvo wrote:

We could use the question above the buttons (the one we use in Paste Check) to show the suggested word and ask the user to replace it.

Good point - this is done and ready for review:

@Esanders it looks good!

Do you know why the "OK" button is not up to dated to the "Change word" proposed in T414987?

Well, (a) it doesn't seem to be listed in the table of copy proposals on that ticket, and (b) it shouldn't be "change word", because a textmatch replacement isn't necessarily going to be a single word.

What about just Replace to match the question above?

Change #1251014 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: Show specific replacement about to take place

https://gerrit.wikimedia.org/r/1251014

Change #1264740 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: action label "replace" instead of "ok"

https://gerrit.wikimedia.org/r/1264740

In T418470#11765882, @bmartinezcalvo wrote:

What about just Replace to match the question above?

Seems reasonable, let's file a separate task.

Went ahead and made T422059 per Ed's comment.