Page MenuHomePhabricator
Create Task
Maniphest T418487

Extension CI broken: CentralAuthSessionProviderTest: undefined option: 'JwtSessionCookieIssuer'
Closed, ResolvedPublic
Actions

Description

Example build.

1) CentralAuthSessionProviderTest::testProvideSessionInfo
MediaWiki\Config\ConfigException: MediaWiki\Config\HashConfig::get: undefined option: 'JwtSessionCookieIssuer'

/workspace/src/includes/Config/HashConfig.php:45
/workspace/src/includes/Session/JwtSessionCookieHelper.php:246
/workspace/src/includes/Session/CookieSessionProvider.php:485
/workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:616
/workspace/src/includes/Session/CookieSessionProvider.php:475
/workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:305
/workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthSessionProviderTest.php:163

2) CentralAuthSessionProviderTest::testPersistSession
MediaWiki\Config\ConfigException: MediaWiki\Config\HashConfig::get: undefined option: 'JwtSessionCookieIssuer'

/workspace/src/includes/Config/HashConfig.php:45
/workspace/src/includes/Session/JwtSessionCookieHelper.php:246
/workspace/src/includes/Session/CookieSessionProvider.php:485
/workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:616
/workspace/src/includes/Session/CookieSessionProvider.php:255
/workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:412
/workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthSessionProviderTest.php:247

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: Fix missing JWT issuer for CentralAuthSessionProviderGergő Tiszamediawiki/extensions/CentralAuthwmf/1.46.0-wmf.17+2 -0
tests: Fix missing JWT issuer for CentralAuthSessionProviderD3r1ck01mediawiki/extensions/CentralAuthmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Feb 26 2026, 2:29 PM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptFeb 26 2026, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lucas_Werkmeister_WMDE added a comment.Feb 26 2026, 2:30 PM

Probably related to Session: Emit JWT cookie in ImmutableSessionProviderWithCookie (T415007: Login with `action=login` and bot password does not create a JWT session cookie) which was merged just now.

hashar added subscribers: matmarex, Tgr, xSavitar, hashar.Feb 26 2026, 2:31 PM

Bartosz has pointed to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1229121 as the root cause.

MediaWiki core being able to break CentralAuth because of lack of integration testing is T333541 :-|

Jdforrester-WMF subscribed.Feb 26 2026, 2:34 PM

Caused by T415007: Login with `action=login` and bot password does not create a JWT session cookie indeed.

gerritbot added a comment.Feb 26 2026, 2:54 PM

Change #1244684 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] tests: Fix missing JWT issuer for CentralAuthSessionProvider

https://gerrit.wikimedia.org/r/1244684

gerritbot added a project: Patch-For-Review.Feb 26 2026, 2:54 PM
• DAlangi_WMF changed the task status from Open to In Progress.Feb 26 2026, 2:57 PM
• DAlangi_WMF claimed this task.
• DAlangi_WMF moved this task from Inbox, needs triage to Kanban on the MediaWiki-Core-Platform-Team board.Feb 26 2026, 3:02 PM
• DAlangi_WMF edited projects, added: MediaWiki-Core-Platform-Team (Kanban); removed: MediaWiki-Core-Platform-Team.
• DAlangi_WMF moved this task from Essential Work to In Progress on the MediaWiki-Core-Platform-Team (Kanban) board.
gerritbot added a comment.Feb 26 2026, 3:43 PM

Change #1244684 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Fix missing JWT issuer for CentralAuthSessionProvider

https://gerrit.wikimedia.org/r/1244684

hashar added a comment.Feb 26 2026, 3:45 PM

The patch has merged and thus the CI tests error should be gone now! 🎉

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2026, 4:32 PM
matmarex closed this task as Resolved.Feb 26 2026, 4:58 PM
gerritbot added a comment.Feb 27 2026, 3:12 PM

Change #1245387 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@wmf/1.46.0-wmf.17] tests: Fix missing JWT issuer for CentralAuthSessionProvider

https://gerrit.wikimedia.org/r/1245387

gerritbot added a project: Patch-For-Review.Feb 27 2026, 3:12 PM
gerritbot added a comment.Feb 27 2026, 3:31 PM

Change #1245387 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.46.0-wmf.17] tests: Fix missing JWT issuer for CentralAuthSessionProvider

https://gerrit.wikimedia.org/r/1245387

Stashbot added a comment.Feb 27 2026, 3:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-27T15:31:54Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1245381|session: Log stack trace for JWT errors]], [[gerrit:1245387|tests: Fix missing JWT issuer for CentralAuthSessionProvider (T418487 T415007)]], [[gerrit:1245382|session: Log stack trace for JWT errors]]

Stashbot mentioned this in T415007: Login with `action=login` and bot password does not create a JWT session cookie.Feb 27 2026, 3:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-27T15:33:49Z] <tgr@deploy2002> tgr: Backport for [[gerrit:1245381|session: Log stack trace for JWT errors]], [[gerrit:1245387|tests: Fix missing JWT issuer for CentralAuthSessionProvider (T418487 T415007)]], [[gerrit:1245382|session: Log stack trace for JWT errors]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Feb 27 2026, 3:40 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-27T15:40:04Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1245381|session: Log stack trace for JWT errors]], [[gerrit:1245387|tests: Fix missing JWT issuer for CentralAuthSessionProvider (T418487 T415007)]], [[gerrit:1245382|session: Log stack trace for JWT errors]] (duration: 08m 11s)

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2026, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits