Page MenuHomePhabricator

hCaptcha: Fix validation errors for x_is_browser being asigned a string value
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR

Description

What happens?:

What should have happened instead?:

  • WikimediaEvents should send the value as an integer

Acceptance Criteria

  • Logstash errors about x_is_browser cease to happen

Related Objects

Event Timeline

Change #1244715 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/WikimediaEvents@master] hcaptcha: Sanitize values of x_is_browser sent on risk_score events

https://gerrit.wikimedia.org/r/1244715

Change #1244718 had a related patch set uploaded (by Kosta Harlan; author: Harroyo-wmf):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.17] hcaptcha: Sanitize values of x_is_browser sent on risk_score events

https://gerrit.wikimedia.org/r/1244718

Change #1244715 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] hcaptcha: Sanitize values of x_is_browser sent on risk_score events

https://gerrit.wikimedia.org/r/1244715

Change #1244718 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.17] hcaptcha: Sanitize values of x_is_browser sent on risk_score events

https://gerrit.wikimedia.org/r/1244718

Mentioned in SAL (#wikimedia-operations) [2026-02-26T17:20:58Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1244718|hcaptcha: Sanitize values of x_is_browser sent on risk_score events (T418505)]]

Mentioned in SAL (#wikimedia-operations) [2026-02-26T17:23:07Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1244718|hcaptcha: Sanitize values of x_is_browser sent on risk_score events (T418505)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-02-26T17:30:58Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1244718|hcaptcha: Sanitize values of x_is_browser sent on risk_score events (T418505)]] (duration: 10m 00s)

hector.arroyo changed the subtype of this task from "Bug Report" to "Production Error".

The original patch was merged, a backport was deployed yesterday afternoon, and we later double-checked that the error was not happening anymore in prod.
Logstash shows the last occurrence of this error being at Feb 26, 2026 @ 19:09:10.173 GMT.

Therefore, I'm closing this task now.